Skip to content

Remove unuseful layer_on() call #23055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2024
Merged

Remove unuseful layer_on() call #23055

merged 2 commits into from
Mar 13, 2024

Conversation

DavidSannier
Copy link
Contributor

Description

layer_on(action.layer_tap.val) is also called from the following set_oneshot_layer(action.layer_tap.val, ONESHOT_START) call

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 11, 2024
@drashna drashna requested a review from a team February 12, 2024 00:30
@drashna drashna merged commit c92277a into qmk:develop Mar 13, 2024
@DavidSannier DavidSannier deleted the remove_layer_on_call branch March 24, 2024 09:07
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@DavidSannier @mechlovin
Remove unuseful layer_on() call (qmk#23055)
cc96bc7
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@DavidSannier @mechlovin
Remove unuseful layer_on() call (qmk#23055)
5defd43
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@DavidSannier @mechlovin
Remove unuseful layer_on() call (qmk#23055)
03980c2
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@DavidSannier @whoisjordangarcia
Remove unuseful layer_on() call (qmk#23055)
4dd3a6d
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@DavidSannier @nuess0r
Remove unuseful layer_on() call (qmk#23055)
e39f18f
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@DavidSannier @Ardakilic
Remove unuseful layer_on() call (qmk#23055)
bd55b1b
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@DavidSannier @MasayukiFukada
Remove unuseful layer_on() call (qmk#23055)
fa24d17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidSannier @drashna @zvecr