Remove midi_ep_task from ChibiOS #23162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has some merge conflicts that need to be resolved. |
|
It should be good now. |
fauxpark
approved these changes
Mar 10, 2024
zvecr
approved these changes
Mar 21, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
MasayukiFukada
pushed a commit
to MasayukiFukada/qmk_firmware
that referenced
this pull request
May 1, 2025
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
midi_ep_taskfunction introduced in #8071 as it seems no longer necessary for MIDI to work properly. This function causes packets arriving during theprotocol_post_taskphase to be unprocessed through theusb_get_midihandler inquantum/midi/qmk_midi.c, as the function simply reads packets and does nothing with them.Types of Changes
Issues Fixed or Closed by This PR
NA
Checklist