Skip to content

Fixup annepro2 #23206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Fixup annepro2 #23206

merged 2 commits into from
Mar 8, 2024

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Mar 3, 2024

Description

  • Moves common configuration to top-level info.json (RGB Matrix, features, & EEPROM)
  • Reduces firmware size (LTO)
  • Removes invalid operations in keymaps

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team March 3, 2024 17:52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In layouts.LAYOUT_60_iso.layout, could ISO Enter key be moved from end of row "y": 1 to end of row "y": 2? to:

  1. conform to 60_iso Community Layout
  2. match KC_ENT placement in iso_default keymap

@drashna drashna requested a review from a team March 8, 2024 10:49
@waffle87 waffle87 merged commit bd1f106 into qmk:develop Mar 8, 2024
@waffle87 waffle87 deleted the fix/ap2 branch March 8, 2024 15:27
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Co-authored-by: Joel Challis <git@zvecr.com>
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants