Skip to content

Fixed keychron q1v1 led config for iso layout #23222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2024
Merged

Fixed keychron q1v1 led config for iso layout #23222

merged 1 commit into from
Mar 10, 2024

Conversation

CromFr
Copy link
Contributor

@CromFr CromFr commented Mar 5, 2024

Description

Current LED config for the Keychron Q1v1 with ISO layout is incorrect:

  • The last LED (right arrow) is never powered on
  • The LEDs for caps lock, up arrow are not correctly placed
  • The LEDs from the bottom rows are shifted (the LED on the B key is instead on the V key)

IMHO it looks like the ISO and ANSI configs got mixed up in commit 38f89df.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@CromFr
Fixed keychron q1v1 led config for iso layout
da43584 
it looks like iso and ansi configs got mixed up in commit 38f89df
@waffle87 waffle87 changed the base branch from master to develop March 5, 2024 17:40
@waffle87 waffle87 requested a review from a team March 5, 2024 17:40
@zvecr zvecr merged commit 729520f into qmk:develop Mar 10, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@CromFr @mechlovin
Fix keychron q1v1 led config for iso layout (qmk#23222)
397ebba
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@CromFr @mechlovin
Fix keychron q1v1 led config for iso layout (qmk#23222)
2584fd8
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@CromFr @mechlovin
Fix keychron q1v1 led config for iso layout (qmk#23222)
c5060e9
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@CromFr @whoisjordangarcia
Fix keychron q1v1 led config for iso layout (qmk#23222)
5204433
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@CromFr @nuess0r
Fix keychron q1v1 led config for iso layout (qmk#23222)
e688c63
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@CromFr @Ardakilic
Fix keychron q1v1 led config for iso layout (qmk#23222)
97f089b
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@CromFr @MasayukiFukada
Fix keychron q1v1 led config for iso layout (qmk#23222)
7dfbae8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CromFr @fauxpark @waffle87 @zvecr