Skip to content

Update BAMFK-1 #23236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2024
Merged

Update BAMFK-1 #23236

merged 5 commits into from
Mar 9, 2024

Conversation

nooges
Copy link
Member

@nooges nooges commented Mar 7, 2024

Description

  • Change RGBLIGHT to RGB_MATRIX
  • Adjust version number so new VIA definition file can be used due to new use of encoder map and RGB Matrix
  • Refactor rules.mk items in info.json

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This was referenced Mar 7, 2024
Merged
Closed
waffle87
waffle87 reviewed Mar 7, 2024
View reviewed changes
@nooges @waffle87
Update keyboards/keebio/bamfk1/info.json
147ec5e 
Co-authored-by: jack <0x6a73@protonmail.com>
zvecr
zvecr requested changes Mar 7, 2024
View reviewed changes
@nooges @zvecr
Move default RGB mode/speed to info.json
32997ab 
Co-authored-by: Joel Challis <git@zvecr.com>
@waffle87 waffle87 requested a review from a team March 8, 2024 15:32
@zvecr zvecr merged commit 1db7ff7 into qmk:develop Mar 9, 2024
@nooges nooges deleted the bamfk-1-update branch March 11, 2024 14:48
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@nooges @mechlovin
Update BAMFK-1 (qmk#23236)
99d35d0 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@nooges @mechlovin
Update BAMFK-1 (qmk#23236)
f3e66b1 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@nooges @mechlovin
Update BAMFK-1 (qmk#23236)
cd7c37d 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@nooges @whoisjordangarcia
Update BAMFK-1 (qmk#23236)
09180c0 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@nooges @nuess0r
Update BAMFK-1 (qmk#23236)
03267a7 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@nooges @Ardakilic
Update BAMFK-1 (qmk#23236)
4b916e0 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@nooges @MasayukiFukada
Update BAMFK-1 (qmk#23236)
610b2ce 
* Bump version number so VIA doesn't choke due to reconfiguration of keys/encoders

* Move rules.mk stuff into info.json, convert RGBLIGHT TO RGB_MATRIX

* Run format-json on info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nooges @zvecr @waffle87