Skip to content

Reject duplicate matrix locations in LAYOUT macros #23273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

Reject duplicate matrix locations in LAYOUT macros #23273

merged 1 commit into from
Mar 13, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 13, 2024 •
edited
Loading

Description

Failure would usually only be caught at compile time, for example....

./.build/obj_zvecr_zv48_f401_default/src/default_keyboard.h:31:32: error: duplicate macro parameter "k0B"
   31 | #define LAYOUT_ortho_4x12(k0B, k0B, k0C, k0D, k0E, k0F, k4F, k4E, k4D, k4C, k4B, k4A, k1A, k1B, k1C, k1D, k1E, k1F, k5F, k5E, k5D, k5C, k5B, k5A, k2A, k2B, k2C, k2D, k2E, k2F, k6F, k6E, k6D, k6C, k6B, k6A, k3A, k3B, k3C, k3D, k3E, k3F, k7F, k7E, k7D, k7C, k7B, k7A) { \

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Mar 13, 2024
@zvecr zvecr merged commit af1ac6b into develop Mar 13, 2024
@zvecr zvecr deleted the lint_layout_dupes branch March 13, 2024 23:04
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @mechlovin
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
f9ba4e7
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @mechlovin
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
aead0d2
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@zvecr @mechlovin
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
504629d
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
2279ccb
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
e388e2a
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
1172966
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@zvecr @MasayukiFukada
Reject duplicate matrix locations in LAYOUT macros (qmk#23273)
06d72a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc