Skip to content

Linworks FAve 87H Keymap Refactor/Bugfix #23292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

noroadsleft
Copy link
Member

Description

Reissuing a previously merged fix1 that was partially reverted by another pull request.

cc @ToastyStoemp (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

linworks_fave87h_default

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Footnotes

  1. https://github.com/qmk/qmk_firmware/pull/18497

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]
Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
@noroadsleft noroadsleft added bug keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 15, 2024
@noroadsleft noroadsleft requested a review from a team March 15, 2024 22:25
@github-actions github-actions bot removed the keyboard label Mar 15, 2024
@zvecr zvecr merged commit 1f8f0f7 into qmk:develop Mar 15, 2024
@noroadsleft noroadsleft deleted the dev/linworks_fave87h branch March 15, 2024 22:39
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
* Refactor keymaps

- use QMK-native keycode aliases
- grid-align keycodes

[refactor]

* Correct key sequence

Moves the keycode representing the right half of a split Backspace to
the number row, after the left half/2u Backspace keycode.

Updates the keycode grid alignment to maintain readability.

[bugfix]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants