Remove RGBLight led[] references
#23311
Merged
+62
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
via
zvecr
approved these changes
Mar 21, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 4, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 4, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 15, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
MasayukiFukada
pushed a commit
to MasayukiFukada/qmk_firmware
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of an effort to move responsibility for the pixel buffer to the LED drivers instead of the RGBLight feature itself. The next part will involve removing the
externed LED array.These were easy-ish, but there are more which actually read from the array instead of writing to it, and there is no real replacement for this. They may end up having to be removed altogether.
Types of Changes
Issues Fixed or Closed by This PR
Checklist