Produce warning if keyboard is not configured via keyboard.json
#23321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
changed the title
keyboard.json has not been used
zvecr
force-pushed
the
warn_keyboard_json_missing
branch
from
d3a56e6 to
8dc1f6f
Compare
zvecr
changed the title
keyboard.json has not been usedkeyboard.json
zvecr
force-pushed
the
warn_keyboard_json_missing
branch
from
8dc1f6f to
0fa8698
Compare
fauxpark
approved these changes
Apr 1, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
MasayukiFukada
pushed a commit
to MasayukiFukada/qmk_firmware
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the many keyboard level migrations to use
keyboard.json, there is currently nothing user facing to show that a keyboard is still using the legacy method ofrules.mk.This PR adds a lint/build warning when a keyboard has fallen back to backwards compatibility. Which after backwards compatibility is removed, can easily be promoted to a build error.
Types of Changes
Issues Fixed or Closed by This PR
Checklist