Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce firmware size of helix/rev3 #23324

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Reduce firmware size of helix/rev3 #23324

merged 1 commit into from
Mar 21, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 21, 2024 •
edited
Loading

Description

Constantly failing with a few bytes either way of oversized.

Removing snprintf gives us about 1k extra to play with.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Mar 21, 2024
@zvecr zvecr requested a review from a team March 21, 2024 12:51
@zvecr zvecr merged commit ae9c538 into develop Mar 21, 2024
3 checks passed
@zvecr zvecr deleted the slim_helix_rev3 branch March 21, 2024 21:54
0x647262 pushed a commit to 0x647262/qmk_firmware that referenced this pull request Apr 26, 2024
@zvecr @0x647262
Reduce firmware size of helix/rev3 (qmk#23324)
973888a
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
@zvecr @PepperLola
Reduce firmware size of helix/rev3 (qmk#23324)
1571337
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Reduce firmware size of helix/rev3 (qmk#23324)
9ae7b04
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@zvecr @nuphy-src
Reduce firmware size of helix/rev3 (qmk#23324)
9c0876b
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@zvecr @AJO-Python
Reduce firmware size of helix/rev3 (qmk#23324)
ebb9e04
jrtex pushed a commit to jrtex/qmk_firmware that referenced this pull request Jul 13, 2024
@zvecr
Reduce firmware size of helix/rev3 (qmk#23324)
273dc81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @waffle87