P3D Spacey Layout Updates #23329
Merged
P3D Spacey Layout Updates #23329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[docs]
The macro `LAYOUT` contains matrix positions that actually do not exist on the PCB. This commit implements `LAYOUT_all` for the purpose of superseding `LAYOUT`. [enhancement]
- use `LAYOUT_all` macro - grid-align keycodes - remove alias for `MO(_FN)` (`MO(1)`) - remove custom keycodes boilerplate [refactor]
- use `LAYOUT_all` macro - grid-align keycodes [refactor]
[enhancement]
[enhancement]
[enhancement]
This macro has been deprecated in favor of `LAYOUT_all`. [enhancement]
noroadsleft
added
enhancement
keyboard
keymap
via
fauxpark
approved these changes
Mar 22, 2024
|
Intended future implementation:
|
dunk2k
approved these changes
Mar 22, 2024
drashna
approved these changes
Mar 29, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
MasayukiFukada
pushed a commit
to MasayukiFukada/qmk_firmware
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LAYOUTThis PR removs the macro
LAYOUTin favor ofLAYOUT_all, because the former was improperly implemented.defaultandviakeymapsLAYOUT_allmacroMO(_FN)(MO(1)) and custom keycode boilerplate fromdefaultkeymapcc @vanillakeyboards (keyboard maintainer)
Types of Changes
Issues Fixed or Closed by This PR
Checklist