Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "w": 1 from keyboards/ #23367

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Remove "w": 1 from keyboards/ #23367

merged 3 commits into from
Mar 30, 2024

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Mar 27, 2024

Description

Remove explicit definition of, default, key width 1 in keyboards/ directory

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k dunk2k changed the title Remove "w": 1 from layouts Remove "w": 1 from keyboards/ Mar 27, 2024
@zvecr zvecr changed the base branch from master to develop March 27, 2024 16:26
@lesshonor
Copy link
Contributor

A few more:

  • keyboards/lucid/velvet_solder/info.json
  • keyboards/enviousdesign/mcro/rev1/info.json
  • keyboards/enviousdesign/delirium/rgb/info.json
  • keyboards/teahouse/ayleen/info.json
  • keyboards/latincompass/latin60rgb/keyboard.json
  • keyboards/skyloong/gk61/pro_48/info.json
  • keyboards/skyloong/gk61/v1/info.json
  • keyboards/skyloong/gk61/pro/info.json
  • keyboards/custommk/evo70_r2/info.json

@dunk2k
Copy link
Contributor Author

dunk2k commented Mar 29, 2024

A few more:

  • keyboards/lucid/velvet_solder/info.json
  • keyboards/enviousdesign/mcro/rev1/info.json
  • keyboards/enviousdesign/delirium/rgb/info.json
  • keyboards/teahouse/ayleen/info.json
  • keyboards/latincompass/latin60rgb/keyboard.json
  • keyboards/skyloong/gk61/pro_48/info.json
  • keyboards/skyloong/gk61/v1/info.json
  • keyboards/skyloong/gk61/pro/info.json
  • keyboards/custommk/evo70_r2/info.json

Thank you kindly, included as per commit a9f3350 🙂

@drashna drashna requested a review from a team March 30, 2024 00:04
@drashna drashna merged commit 86e7df0 into qmk:develop Mar 30, 2024
2 of 3 checks passed
@dunk2k dunk2k deleted the rm_w1 branch March 30, 2024 09:53
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@dunk2k @whoisjordangarcia
Remove "w": 1 from keyboards/ (qmk#23367)
c5f4c9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@lesshonor lesshonor lesshonor approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dunk2k @lesshonor @drashna @fauxpark