Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: flehrad/bigswitch #23384

Merged
merged 1 commit into from
Apr 1, 2024
Merged

refactor: flehrad/bigswitch #23384

merged 1 commit into from
Apr 1, 2024

Conversation

lesshonor
Copy link
Contributor

Description

  • Enable mousekeys and extrakeys for Configurator users; formally disable command (config.h settings made it unusable anyway; this keyboard has a single key)
  • Reformat keyboard.json
  • "Default-ish" RGB settings (forced switch to rainbow_swirl on startup) converted to QMK default settings
  • Switch to standard keycode constant
  • Remove excess transparent layers from and add keycode to via keymap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lesshonor
refactor: flehrad/bigswitch
56f0e3e 
* Command fully disabled, mousekeys and extrakeys enabled

* keyboard.json reformatted

* "Default-ish" RGB startup settings formalized into QMK defaults

* Use standard keycode constant in keymaps

* Transparent layers removed from and keycode added to via keymap
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 1, 2024
@waffle87 waffle87 merged commit a922627 into qmk:develop Apr 1, 2024
3 checks passed
@lesshonor lesshonor deleted the refactor/flehrad/bigswitch branch April 1, 2024 16:48
0x647262 pushed a commit to 0x647262/qmk_firmware that referenced this pull request Apr 26, 2024
@lesshonor @0x647262
refactor: flehrad/bigswitch (qmk#23384)
791b104
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
@lesshonor @PepperLola
refactor: flehrad/bigswitch (qmk#23384)
da31559
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@lesshonor @whoisjordangarcia
refactor: flehrad/bigswitch (qmk#23384)
9e79ab3
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@lesshonor @nuphy-src
refactor: flehrad/bigswitch (qmk#23384)
a342b25
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@lesshonor @AJO-Python
refactor: flehrad/bigswitch (qmk#23384)
eb32350
jrtex pushed a commit to jrtex/qmk_firmware that referenced this pull request Jul 13, 2024
@lesshonor
refactor: flehrad/bigswitch (qmk#23384)
108182a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lesshonor @zvecr @waffle87