Remove quantum.h includes from keyboard code
#23394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint & build failures are unrelated. |
dunk2k
approved these changes
Apr 2, 2024
waffle87
approved these changes
Apr 2, 2024
14 tasks
0x647262
pushed a commit
to 0x647262/qmk_firmware
that referenced
this pull request
Apr 26, 2024
PepperLola
pushed a commit
to PepperLola/qmk_firmware
that referenced
this pull request
May 29, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuphy-src
pushed a commit
to nuphy-src/qmk_firmware
that referenced
this pull request
Jul 2, 2024
AJO-Python
pushed a commit
to AJO-Python/qmk_firmware
that referenced
this pull request
Jul 7, 2024
jrtex
pushed a commit
to jrtex/qmk_firmware
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of these couldn't quite have
quantum.heliminated as they actually do use symbols declared in it rather than simply using the header for its own includes.There are also a bunch more left, most of which are
lib/-based (bongocat/layer state etc) or the various EC implementations. I'll do those in a separate PR.Types of Changes
Issues Fixed or Closed by This PR
Checklist