Skip to content

40percentclub/gherkin: remove CONVERT_TO at keyboard level #23396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2024
Merged

40percentclub/gherkin: remove CONVERT_TO at keyboard level #23396

merged 2 commits into from
Apr 2, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 2, 2024

Description

Same as #23395.

Indicator code also moved from the default keymap to keyboard level. Since the KB2040 does not actually have the same two LEDs as the Pro Micro has on D5 and B0, only the pro_micro revision of this board has the indicators object set.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 2, 2024 11:34
zvecr
zvecr reviewed Apr 2, 2024
View reviewed changes
@zvecr zvecr merged commit 1bea8b9 into qmk:develop Apr 2, 2024
@fauxpark fauxpark deleted the gherkin-remove-converter branch April 2, 2024 14:36
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
40percentclub/gherkin: remove CONVERT_TO at keyboard level (qmk#23396)
54997a2
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
40percentclub/gherkin: remove CONVERT_TO at keyboard level (qmk#23396)
7838727
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
40percentclub/gherkin: remove CONVERT_TO at keyboard level (qmk#23396)
cdaab3b
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@fauxpark @MasayukiFukada
40percentclub/gherkin: remove CONVERT_TO at keyboard level (qmk#23396)
fc5b2ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr