Skip to content

Fix spaceholdings/nebula68b #23399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix spaceholdings/nebula68b #23399

merged 2 commits into from
Apr 2, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 2, 2024

Description

Keyboard incorrectly contains nested build targets.

$ qmk lint -kb spaceholdings/nebula68b
Ψ Lint check passed!
$ qmk lint -kb spaceholdings/nebula68b/hs
☒ spaceholdings/nebula68b/hs: Invalid keyboard.json location detected: keyboards/spaceholdings/nebula68b/keyboard.json.
☒ spaceholdings/nebula68b/hs: Invalid keyboard.json location detected: keyboards/spaceholdings/nebula68b/keyboard.json.
☒ spaceholdings/nebula68b/hs: Errors found when generating info.json.
☒ spaceholdings/nebula68b/hs: Invalid keyboard.json location detected: keyboards/spaceholdings/nebula68b/keyboard.json.
☒ spaceholdings/nebula68b/hs: Invalid keyboard.json location detected: keyboards/spaceholdings/nebula68b/keyboard.json.
☒ Lint check failed for: spaceholdings/nebula68b/hs

With the enhanced linting it is now correctly flagging that its structure is wrong.

Content has been migrated to a new solder build target to avoid the above issues.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 2, 2024
@zvecr zvecr added the bug label Apr 2, 2024
@zvecr zvecr merged commit 73daecd into develop Apr 2, 2024
@zvecr zvecr deleted the spaceholdings_nebula68b branch April 2, 2024 23:36
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants