Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KB name change to Part.1-75-HS #23403

Merged
merged 1 commit into from
May 19, 2024
Merged

KB name change to Part.1-75-HS #23403

merged 1 commit into from
May 19, 2024

Conversation

Vertex-kb
Copy link
Contributor

KB name change to Part.1-75-HS

Description

KB name change to Part.1-75-HS

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but per the PR checklist you must target the develop branch, not master.

@Vertex-kb Vertex-kb closed this Apr 10, 2024
@zvecr zvecr reopened this Apr 10, 2024
@zvecr zvecr changed the base branch from master to develop April 10, 2024 07:17
@drashna
Copy link
Member

drashna commented May 1, 2024

There is a merge conflict here that needs resolving (eg, rebasing)

@drashna drashna merged commit 48c0b60 into qmk:develop May 19, 2024
3 checks passed
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants