Skip to content

Tidy up keyboards/zvecr #23418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2024
Merged

Tidy up keyboards/zvecr #23418

merged 2 commits into from
Apr 5, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 4, 2024 •
edited
Loading

Description

Figured I should at least make sure my folder aligns to current code guidelines.

  • Aligns to keyboard.json
  • Removes DEFAULT_FOLDER
  • Fixes lint warnings on missing headers

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Apr 4, 2024
View reviewed changes
@zvecr zvecr requested a review from fauxpark April 5, 2024 00:14
@daskygit
Copy link
Member

daskygit commented Apr 5, 2024

could swap over the palSetLineMode to gpio_set_pin_output_push_pull/gpio_set_pin_output_open_drain

@zvecr zvecr requested a review from daskygit April 5, 2024 01:32
@zvecr zvecr merged commit fd17ae3 into develop Apr 5, 2024
@zvecr zvecr deleted the tidy_zvecr branch April 5, 2024 01:38
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Tidy up keyboards/zvecr (qmk#23418)
2d2255b
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Tidy up keyboards/zvecr (qmk#23418)
07bcfae
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Tidy up keyboards/zvecr (qmk#23418)
0dd9119
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@zvecr @MasayukiFukada
Tidy up keyboards/zvecr (qmk#23418)
c3080db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@daskygit daskygit daskygit approved these changes

+1 more reviewer

@dunk2k dunk2k dunk2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @daskygit @fauxpark @dunk2k