Skip to content

Rename process_{led,rgb}_matrix() #23422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

Rename process_{led,rgb}_matrix() #23422

merged 1 commit into from
Apr 5, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 5, 2024

Description

Avoids naming collision with future process_keycode handlers for LED and RGB Matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 5, 2024 08:24
@zvecr zvecr merged commit 9fa91ad into qmk:develop Apr 5, 2024
@fauxpark fauxpark deleted the led-rgb-matrix-process-rename branch April 5, 2024 14:45
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
Rename process_{led,rgb}_matrix() (qmk#23422)
bf2b090
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Rename process_{led,rgb}_matrix() (qmk#23422)
c2d2bb3
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
Rename process_{led,rgb}_matrix() (qmk#23422)
2011704
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@fauxpark @MasayukiFukada
Rename process_{led,rgb}_matrix() (qmk#23422)
5f91c5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @KarlK90 @zvecr