Skip to content

Data-Driven Keyboard Conversions: B #23425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2024
Merged

Data-Driven Keyboard Conversions: B #23425

merged 2 commits into from
Apr 11, 2024

Conversation

noroadsleft
Copy link
Member

Description

Converts configuration definitions and rules to data-driven where applicable. Renames info.json to keyboard.json in instances where rules.mk can be safely deleted.

  • keyboards with names beginning with b

⚠️ NOTE ⚠️ : I've deliberately skipped editing anything in keyboards/bastardkb/ because there's so many nested variants that I couldn't be bothered. I'll come back around for those.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested review from zvecr and a team April 5, 2024 18:07
fauxpark
fauxpark requested changes Apr 6, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last note: NoScript really seems to disagree with the sheer size of these PRs making it painfully laggy (weird, it's usually RGH trying to do all the whitespace chars). Extracting the locking migrations to separate PRs would probably be faster for me to review.

@noroadsleft noroadsleft force-pushed the dev/dd_json_b branch 2 times, most recently from c23d1f7 to 80d2446 Compare April 7, 2024 08:28
fauxpark
fauxpark reviewed Apr 8, 2024
View reviewed changes
@burkfers
Copy link
Contributor

burkfers commented Apr 8, 2024 •
edited
Loading

re bastardkb: A removal of legacy variants and flattening the directory structure is planned - I have already begun work but need some more time and internal review; We should coordinate to avoid duplication of efforts.

@noroadsleft
Data-driven keyboard conversions: B
4c8d0c4 
Converts configuration definitions and rules to data-driven where
applicable. Renames `info.json` to `keyboard.json` in instances where
`rules.mk` can be safely deleted.

Affects:

  - `bacca70`
  - `baguette`
  - `baion_808`
  - `bajjak`
  - `bandominedoni`
  - `bantam44`
  - `barleycorn_smd`
  - `barracuda`
  - `basekeys/slice`
  - `basekeys/trifecta`
  - `basketweave`
  - `bastardkb/dilemma/4x6_4`
  - `bbrfkr/dynamis`
  - `bear_face`
  - `beatervan`
  - `bemeier/bmek`
  - `biacco42/ergo42`
  - `biacco42/meishi`
  - `biacco42/meishi2`
  - `binepad/bn003`
  - `binepad/bn009/r1`
  - `binepad/bnr1`
  - `bioi/g60`
  - `bioi/g60ble`
  - `bioi/morgan65`
  - `bioi/s65`
  - `blackplum`
  - `blank/blank01`
  - `blank_tehnologii/manibus`
  - `blockey`
  - `bluebell/swoop`
  - `boardrun/bizarre`
  - `boardrun/classic`
  - `boardsource/equals/48`
  - `boardsource/equals/60`
  - `boardwalk`
  - `bop`
  - `boston`
  - `boston_meetup/2019`
  - `box75`
  - `bpiphany/four_banger`
  - `bpiphany/frosty_flake`
  - `bpiphany/ghost_squid`
  - `bpiphany/hid_liber`
  - `bpiphany/kitten_paw`
  - `bpiphany/tiger_lily`
  - `bpiphany/unloved_bastard`
  - `bt66tech/bt66tech60`
  - `bubble75/hotswap`
  - `budgy`
  - `buildakb/potato65`
  - `buildakb/potato65hs`
  - `buildakb/potato65s`
  - `buzzard`
@noroadsleft
Add Missing LOCKING_*_ENABLE settings
b1659b6 
Fixing instances of `LOCKING_SUPPORT_ENABLE` and `LOCKING_RESYNC_ENABLE`
that didn't get transferred.

Affects:

  - `basekeys/slice/rev1`
  - `basekeys/slice/rev1_rgb`
@noroadsleft noroadsleft merged commit cb81913 into qmk:develop Apr 11, 2024
@noroadsleft noroadsleft deleted the dev/dd_json_b branch April 11, 2024 21:21
@noroadsleft noroadsleft mentioned this pull request Apr 27, 2024
Merged
14 tasks
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@noroadsleft @whoisjordangarcia
Data-Driven Keyboard Conversions: B (qmk#23425)
cac65e7 
Converts configuration definitions and rules to data-driven where
applicable. Renames `info.json` to `keyboard.json` in instances where
`rules.mk` can be safely deleted.

Affects:

  - `bacca70`
  - `baguette`
  - `baion_808`
  - `bajjak`
  - `bandominedoni`
  - `bantam44`
  - `barleycorn_smd`
  - `barracuda`
  - `basekeys/slice/rev1`
  - `basekeys/slice/rev1_rgb`
  - `basekeys/trifecta`
  - `basketweave`
  - `bastardkb/dilemma/4x6_4`
  - `bbrfkr/dynamis`
  - `bear_face`
  - `beatervan`
  - `bemeier/bmek`
  - `biacco42/ergo42`
  - `biacco42/meishi`
  - `biacco42/meishi2`
  - `binepad/bn003`
  - `binepad/bn009/r1`
  - `binepad/bnr1`
  - `bioi/g60`
  - `bioi/g60ble`
  - `bioi/morgan65`
  - `bioi/s65`
  - `blackplum`
  - `blank/blank01`
  - `blank_tehnologii/manibus`
  - `blockey`
  - `bluebell/swoop`
  - `boardrun/bizarre`
  - `boardrun/classic`
  - `boardsource/equals/48`
  - `boardsource/equals/60`
  - `boardwalk`
  - `bop`
  - `boston`
  - `boston_meetup/2019`
  - `box75`
  - `bpiphany/four_banger`
  - `bpiphany/frosty_flake`
  - `bpiphany/ghost_squid`
  - `bpiphany/hid_liber`
  - `bpiphany/kitten_paw`
  - `bpiphany/tiger_lily`
  - `bpiphany/unloved_bastard`
  - `bt66tech/bt66tech60`
  - `bubble75/hotswap`
  - `budgy`
  - `buildakb/potato65`
  - `buildakb/potato65hs`
  - `buildakb/potato65s`
  - `buzzard`
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@noroadsleft @nuess0r
Data-Driven Keyboard Conversions: B (qmk#23425)
44f3bbf 
Converts configuration definitions and rules to data-driven where
applicable. Renames `info.json` to `keyboard.json` in instances where
`rules.mk` can be safely deleted.

Affects:

  - `bacca70`
  - `baguette`
  - `baion_808`
  - `bajjak`
  - `bandominedoni`
  - `bantam44`
  - `barleycorn_smd`
  - `barracuda`
  - `basekeys/slice/rev1`
  - `basekeys/slice/rev1_rgb`
  - `basekeys/trifecta`
  - `basketweave`
  - `bastardkb/dilemma/4x6_4`
  - `bbrfkr/dynamis`
  - `bear_face`
  - `beatervan`
  - `bemeier/bmek`
  - `biacco42/ergo42`
  - `biacco42/meishi`
  - `biacco42/meishi2`
  - `binepad/bn003`
  - `binepad/bn009/r1`
  - `binepad/bnr1`
  - `bioi/g60`
  - `bioi/g60ble`
  - `bioi/morgan65`
  - `bioi/s65`
  - `blackplum`
  - `blank/blank01`
  - `blank_tehnologii/manibus`
  - `blockey`
  - `bluebell/swoop`
  - `boardrun/bizarre`
  - `boardrun/classic`
  - `boardsource/equals/48`
  - `boardsource/equals/60`
  - `boardwalk`
  - `bop`
  - `boston`
  - `boston_meetup/2019`
  - `box75`
  - `bpiphany/four_banger`
  - `bpiphany/frosty_flake`
  - `bpiphany/ghost_squid`
  - `bpiphany/hid_liber`
  - `bpiphany/kitten_paw`
  - `bpiphany/tiger_lily`
  - `bpiphany/unloved_bastard`
  - `bt66tech/bt66tech60`
  - `bubble75/hotswap`
  - `budgy`
  - `buildakb/potato65`
  - `buildakb/potato65hs`
  - `buildakb/potato65s`
  - `buzzard`
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@noroadsleft @Ardakilic
Data-Driven Keyboard Conversions: B (qmk#23425)
1d7a6d5 
Converts configuration definitions and rules to data-driven where
applicable. Renames `info.json` to `keyboard.json` in instances where
`rules.mk` can be safely deleted.

Affects:

  - `bacca70`
  - `baguette`
  - `baion_808`
  - `bajjak`
  - `bandominedoni`
  - `bantam44`
  - `barleycorn_smd`
  - `barracuda`
  - `basekeys/slice/rev1`
  - `basekeys/slice/rev1_rgb`
  - `basekeys/trifecta`
  - `basketweave`
  - `bastardkb/dilemma/4x6_4`
  - `bbrfkr/dynamis`
  - `bear_face`
  - `beatervan`
  - `bemeier/bmek`
  - `biacco42/ergo42`
  - `biacco42/meishi`
  - `biacco42/meishi2`
  - `binepad/bn003`
  - `binepad/bn009/r1`
  - `binepad/bnr1`
  - `bioi/g60`
  - `bioi/g60ble`
  - `bioi/morgan65`
  - `bioi/s65`
  - `blackplum`
  - `blank/blank01`
  - `blank_tehnologii/manibus`
  - `blockey`
  - `bluebell/swoop`
  - `boardrun/bizarre`
  - `boardrun/classic`
  - `boardsource/equals/48`
  - `boardsource/equals/60`
  - `boardwalk`
  - `bop`
  - `boston`
  - `boston_meetup/2019`
  - `box75`
  - `bpiphany/four_banger`
  - `bpiphany/frosty_flake`
  - `bpiphany/ghost_squid`
  - `bpiphany/hid_liber`
  - `bpiphany/kitten_paw`
  - `bpiphany/tiger_lily`
  - `bpiphany/unloved_bastard`
  - `bt66tech/bt66tech60`
  - `bubble75/hotswap`
  - `budgy`
  - `buildakb/potato65`
  - `buildakb/potato65hs`
  - `buildakb/potato65s`
  - `buzzard`
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@noroadsleft @MasayukiFukada
Data-Driven Keyboard Conversions: B (qmk#23425)
994102c 
Converts configuration definitions and rules to data-driven where
applicable. Renames `info.json` to `keyboard.json` in instances where
`rules.mk` can be safely deleted.

Affects:

  - `bacca70`
  - `baguette`
  - `baion_808`
  - `bajjak`
  - `bandominedoni`
  - `bantam44`
  - `barleycorn_smd`
  - `barracuda`
  - `basekeys/slice/rev1`
  - `basekeys/slice/rev1_rgb`
  - `basekeys/trifecta`
  - `basketweave`
  - `bastardkb/dilemma/4x6_4`
  - `bbrfkr/dynamis`
  - `bear_face`
  - `beatervan`
  - `bemeier/bmek`
  - `biacco42/ergo42`
  - `biacco42/meishi`
  - `biacco42/meishi2`
  - `binepad/bn003`
  - `binepad/bn009/r1`
  - `binepad/bnr1`
  - `bioi/g60`
  - `bioi/g60ble`
  - `bioi/morgan65`
  - `bioi/s65`
  - `blackplum`
  - `blank/blank01`
  - `blank_tehnologii/manibus`
  - `blockey`
  - `bluebell/swoop`
  - `boardrun/bizarre`
  - `boardrun/classic`
  - `boardsource/equals/48`
  - `boardsource/equals/60`
  - `boardwalk`
  - `bop`
  - `boston`
  - `boston_meetup/2019`
  - `box75`
  - `bpiphany/four_banger`
  - `bpiphany/frosty_flake`
  - `bpiphany/ghost_squid`
  - `bpiphany/hid_liber`
  - `bpiphany/kitten_paw`
  - `bpiphany/tiger_lily`
  - `bpiphany/unloved_bastard`
  - `bt66tech/bt66tech60`
  - `bubble75/hotswap`
  - `budgy`
  - `buildakb/potato65`
  - `buildakb/potato65hs`
  - `buildakb/potato65s`
  - `buzzard`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @burkfers @fauxpark