Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Chapter1 #23452

Merged
merged 8 commits into from
Apr 12, 2024
Merged

Added Chapter1 #23452

merged 8 commits into from
Apr 12, 2024

Conversation

cheezi0747
Copy link
Contributor

Description

Adds the Chapter 1 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 10, 2024
waffle87
waffle87 requested changes Apr 10, 2024
View reviewed changes
keyboards/mechstudio/chapter1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mechstudio/chapter1/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mechstudio/chapter1/rules.mk Outdated Show resolved Hide resolved
keyboards/mechstudio/chapter1/info.json Show resolved Hide resolved
keyboards/mechstudio/chapter1/info.json Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team April 10, 2024 20:34
cheezi0747 and others added 6 commits April 10, 2024 22:57
@cheezi0747 @waffle87
Update keyboards/mechstudio/chapter1/keymaps/default/keymap.c
acf3b00 
Co-authored-by: jack <0x6a73@protonmail.com>
@cheezi0747 @waffle87
Update keyboards/mechstudio/chapter1/keymaps/via/keymap.c
3fcc9d4 
Co-authored-by: jack <0x6a73@protonmail.com>
@cheezi0747 @waffle87
Update keyboards/mechstudio/chapter1/info.json
da5e4ae 
Co-authored-by: jack <0x6a73@protonmail.com>
@cheezi0747 @waffle87
Update keyboards/mechstudio/chapter1/info.json
fc88ca1 
Co-authored-by: jack <0x6a73@protonmail.com>
@cheezi0747 @waffle87
Update keyboards/mechstudio/chapter1/rules.mk
6a1c761 
Co-authored-by: jack <0x6a73@protonmail.com>
@cheezi0747 @lesshonor
Update keyboards/mechstudio/chapter1/info.json
737d93d 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
@casuanoob casuanoob mentioned this pull request Apr 11, 2024
Merged
7 tasks
casuanoob
casuanoob approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@casuanoob casuanoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Only thing I see is that bootmagic is apparently configured for matrix [1, 0] but the readme bootmagic instruction retains the default "matrix position 0, 0" boilerplate.

@drashna drashna merged commit 244b714 into qmk:develop Apr 12, 2024
3 checks passed
@cheezi0747 cheezi0747 deleted the chapter1 branch April 12, 2024 06:41
0x647262 pushed a commit to 0x647262/qmk_firmware that referenced this pull request Apr 26, 2024
@cheezi0747 @waffle87
@lesshonor @0x647262
[Keyboard] Add Chapter1 (qmk#23452)
d86cd1f 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
@cheezi0747 @waffle87
@lesshonor @PepperLola
[Keyboard] Add Chapter1 (qmk#23452)
63ee768 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@cheezi0747 @waffle87
@lesshonor @whoisjordangarcia
[Keyboard] Add Chapter1 (qmk#23452)
6eb73d1 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
@cheezi0747 @waffle87
@lesshonor @nuphy-src
[Keyboard] Add Chapter1 (qmk#23452)
6b6b092 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@cheezi0747 @waffle87
@lesshonor @AJO-Python
[Keyboard] Add Chapter1 (qmk#23452)
f441c59 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
jrtex pushed a commit to jrtex/qmk_firmware that referenced this pull request Jul 13, 2024
@cheezi0747 @waffle87 @lesshonor
[Keyboard] Add Chapter1 (qmk#23452)
17ea777 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@waffle87 waffle87 waffle87 approved these changes

@casuanoob casuanoob casuanoob approved these changes

@lesshonor lesshonor Awaiting requested review from lesshonor

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cheezi0747 @drashna @fauxpark @waffle87 @lesshonor @casuanoob