Skip to content

Migrate build target markers to keyboard.json - X #23460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

Migrate build target markers to keyboard.json - X #23460

merged 1 commit into from
Apr 12, 2024
+272 −609

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 12, 2024

Description

Manual update of rules.mk content

  • removal of rules.mk where possible
  • info.json -> keyboard.json

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team April 12, 2024 02:09
@zvecr zvecr force-pushed the keyboard_json_x branch from 0dd4a95 to 86a0024 Compare April 12, 2024 03:31
@zvecr zvecr merged commit 45b710f into develop Apr 12, 2024
@zvecr zvecr deleted the keyboard_json_x branch April 12, 2024 03:36
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Migrate build target markers to keyboard.json - X (qmk#23460)
e50bedb
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Migrate build target markers to keyboard.json - X (qmk#23460)
df9a536
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Migrate build target markers to keyboard.json - X (qmk#23460)
59ce63f
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@zvecr @MasayukiFukada
Migrate build target markers to keyboard.json - X (qmk#23460)
527f40a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark