Skip to content

Corrections to split keyboard migrations #23462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

Corrections to split keyboard migrations #23462

merged 1 commit into from
Apr 12, 2024
+29 −144

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 12, 2024 •
edited
Loading

Description

#21410 had some issues that require addressing,

  • Duplication of existing config
  • Introducing info.json files for keyboards with a single revision

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Apr 12, 2024
@zvecr zvecr requested a review from a team April 12, 2024 05:06
tzarc
tzarc approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default keymap SHA1's identical.

@zvecr zvecr merged commit 214e091 into develop Apr 12, 2024
@zvecr zvecr deleted the 21410_fixes branch April 12, 2024 12:44
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Corrections to split keyboard migrations (qmk#23462)
12f06a7
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Corrections to split keyboard migrations (qmk#23462)
07eda9b
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Corrections to split keyboard migrations (qmk#23462)
3011d5c
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@zvecr @MasayukiFukada
Corrections to split keyboard migrations (qmk#23462)
df14603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

+1 more reviewer

@dunk2k dunk2k dunk2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @tzarc @noroadsleft @dunk2k