Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate build target markers to keyboard.json - HI #23540

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Migrate build target markers to keyboard.json - HI #23540

merged 2 commits into from
Apr 17, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 17, 2024

Description

Manual update of rules.mk content

  • removal of rules.mk where possible
  • info.json -> keyboard.json

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team April 17, 2024 00:35
@zvecr zvecr merged commit e869c80 into develop Apr 17, 2024
1 of 3 checks passed
@zvecr zvecr deleted the keyboard_json_hi branch April 17, 2024 01:49
0x647262 pushed a commit to 0x647262/qmk_firmware that referenced this pull request Apr 26, 2024
@zvecr @0x647262
Migrate build target markers to keyboard.json - HI (qmk#23540)
618de52
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
@zvecr @PepperLola
Migrate build target markers to keyboard.json - HI (qmk#23540)
25e484d
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Migrate build target markers to keyboard.json - HI (qmk#23540)
1e37bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @fauxpark