Data-Driven Keyboard Conversions: Mechlovin #23624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/adelais/rgb_led/rev1` - `mechlovin/adelais/rgb_led/rev2` - `mechlovin/adelais/rgb_led/rev3` - `mechlovin/adelais/standard_led/arm/rev2` - `mechlovin/adelais/standard_led/arm/rev3` - `mechlovin/adelais/standard_led/arm/rev4/apm32f103` - `mechlovin/adelais/standard_led/arm/rev4/stm32f303` - `mechlovin/adelais/standard_led/avr/rev1`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/delphine/mono_led` - `mechlovin/delphine/rgb_led`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/hannah60rgb/rev1` - `mechlovin/hannah60rgb/rev2`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/hannah65/rev1/haus`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/hannah910/rev1` - `mechlovin/hannah910/rev2` - `mechlovin/hannah910/rev3`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/hex4b/rev1` - `mechlovin/hex4b/rev2`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/jay60`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/mechlovin9/rev1` - `mechlovin/mechlovin9/rev2` - `mechlovin/mechlovin9/rev3`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/olly/bb`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/olly/jf/rev1` - `mechlovin/olly/jf/rev2`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/serratus`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/th1800`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/zed1800/oreum` - `mechlovin/zed1800/saber` - `mechlovin/zed1800/zepsody`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/zed65/910` - `mechlovin/zed65/mono_led` - `mechlovin/zed65/no_backlight/retro66` - `mechlovin/zed65/no_backlight/wearhaus66` - `mechlovin/zed65/rev1`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/infinity87/rev1/rogue87` - `mechlovin/infinity87/rev1/rouge87` - `mechlovin/infinity87/rev1/standard` - `mechlovin/infinity87/rev2` - `mechlovin/infinity87/rgb_rev1`
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `mechlovin/infinity875`
fauxpark
approved these changes
Apr 27, 2024
noroadsleft
changed the title
Previous data-driven conversions inadvertently disabled some features that were enabled prior to conversion. This commit restores the pre-DD configurations. Affects: - `mechlovin/adelais/standard_led/arm/rev4/apm32f103` - `mechlovin/adelais/standard_led/arm/rev4/stm32f303` - `mechlovin/infinity87/rev1/standard`
zvecr
approved these changes
Apr 27, 2024
PepperLola
pushed a commit
to PepperLola/qmk_firmware
that referenced
this pull request
May 29, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuphy-src
pushed a commit
to nuphy-src/qmk_firmware
that referenced
this pull request
Jul 2, 2024
AJO-Python
pushed a commit
to AJO-Python/qmk_firmware
that referenced
this pull request
Jul 7, 2024
jrtex
pushed a commit
to jrtex/qmk_firmware
that referenced
this pull request
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts
rules.mkentries to data-driven where applicable. Renamesinfo.jsontokeyboard.jsonin instances whererules.mkcan be safely deleted.mechlovin/Types of Changes
Checklist