Skip to content

gh80_3000 - Enable indicator LED functionality #23633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2024
Merged

gh80_3000 - Enable indicator LED functionality #23633

merged 5 commits into from
Apr 30, 2024

Conversation

gaclee3b
Copy link
Contributor

Description

Add indicator LED functionality at the config.h level that seems to be non-functional from old legacy code in the keycap.c files.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Num / scroll / caps lock indicator LEDs are tested with new code and now work.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@gaclee3b gaclee3b changed the base branch from master to develop April 29, 2024 10:46
zvecr
zvecr reviewed Apr 29, 2024
View reviewed changes
@zvecr zvecr changed the title enable indicator LED functionality gh80_3000 - Enable indicator LED functionality Apr 29, 2024
@drashna drashna merged commit b4b222a into qmk:develop Apr 30, 2024
@noroadsleft noroadsleft mentioned this pull request May 1, 2024
Merged
14 tasks
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@gaclee3b @whoisjordangarcia
gh80_3000 - Enable indicator LED functionality (qmk#23633)
6c5dad9 
Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com>
@gaclee3b gaclee3b deleted the fix_gh80_3k branch July 1, 2024 06:07
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@gaclee3b @nuess0r
gh80_3000 - Enable indicator LED functionality (qmk#23633)
4e84728 
Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com>
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@gaclee3b @Ardakilic
gh80_3000 - Enable indicator LED functionality (qmk#23633)
9cb8887 
Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com>
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@gaclee3b @MasayukiFukada
gh80_3000 - Enable indicator LED functionality (qmk#23633)
0dbfa76 
Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaclee3b @drashna @zvecr