-
-
Notifications
You must be signed in to change notification settings - Fork 37.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for encoders and support ENCODER_MAP_ENABLE on Planck rev7 #23967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jun 20, 2024
ykeisuke
force-pushed
the
fix/planck-v7-with-encoder
branch
from
June 21, 2024 07:37
280c1d4
to
78ffe75
Compare
ykeisuke
force-pushed
the
fix/planck-v7-with-encoder
branch
3 times, most recently
from
June 24, 2024 13:47
c81492d
to
f52be72
Compare
tzarc
reviewed
Jun 24, 2024
sigprof
reviewed
Jun 25, 2024
ykeisuke
force-pushed
the
fix/planck-v7-with-encoder
branch
from
June 25, 2024 14:42
1cf0cc6
to
e34700f
Compare
ykeisuke
force-pushed
the
fix/planck-v7-with-encoder
branch
3 times, most recently
from
June 29, 2024 06:54
634f9c4
to
45167b6
Compare
drashna
approved these changes
Jul 3, 2024
2 tasks
tzarc
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, just cleanup and rewording.
ykeisuke
force-pushed
the
fix/planck-v7-with-encoder
branch
from
July 7, 2024 15:03
98c3307
to
781d637
Compare
github-actions
bot
added
documentation
via
Adds via keymap and/or updates keyboard for via support
labels
Jul 7, 2024
* Fix for encoders * Support ENCODER_MAP_ENABLE feature * Update readme.md
…AP_ENABLE, play melody.
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
ykeisuke
force-pushed
the
fix/planck-v7-with-encoder
branch
from
July 7, 2024 17:05
50961d3
to
b25c466
Compare
github-actions
bot
removed
documentation
via
Adds via keymap and/or updates keyboard for via support
labels
Jul 7, 2024
@tzarc Thank you very much for your suggest changes. I did commit your suggestions and define |
tzarc
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENCODER_MAP_ENABLE
feature on Planck rev7Types of Changes
Issues Fixed or Closed by This PR
Checklist