Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change suspend condition check order on ChibiOS #24020

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Change suspend condition check order on ChibiOS #24020

merged 1 commit into from
Jul 4, 2024

Conversation

drashna
Copy link
Member

@drashna drashna commented Jun 29, 2024 •
edited
Loading

Description

Specifically, it seems on some systems that the sync doesn't happen correctly, and changing the order should address the issue by always calling suspend_wakeup_condition, which calls matrix_scan

I haven't experienced this issue, so I can't really test it.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Change suspend condition check on ChibiOS
a854c96 
Specifically, it seems on some systems that the sync doesn't happen correctly, and changing the order should address the issue
@drashna drashna requested a review from a team June 29, 2024 18:52
@github-actions github-actions bot added the core label Jun 29, 2024
@drashna drashna changed the title Change suspend condition check on ChibiOS Change suspend condition check order on ChibiOS Jun 29, 2024
@tzarc tzarc merged commit bdca931 into qmk:develop Jul 4, 2024
4 checks passed
@zvecr zvecr mentioned this pull request Jul 5, 2024
Merged
14 tasks
@drashna drashna deleted the fix/split_suspend branch July 9, 2024 04:00
TheShige pushed a commit to TheShige/qmk_firmware that referenced this pull request Jul 26, 2024
@drashna @TheShige
Change suspend condition check order on ChibiOS (qmk#24020)
50e37d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @tzarc