Skip to content

Allow for get_hardware_id() to be used for serial number. #24053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 6, 2024
Merged

Allow for get_hardware_id() to be used for serial number. #24053

merged 10 commits into from
Oct 6, 2024

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 5, 2024 •
edited
Loading

Description

As per title, and discussed on Discord. SERIAL_NUMBER takes precedence, otherwise the platform will default to on/off where appropriate.
Currently, only ChibiOS-based builds default to on.

When on, get_hardware_id() is used to generate a hex string, used as the serial number.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 5, 2024 03:03
@github-actions github-actions bot added the core label Jul 5, 2024
@tzarc tzarc force-pushed the hardware-id-serial-number branch from 6610184 to eb43683 Compare July 5, 2024 04:51
zvecr
zvecr reviewed Jul 5, 2024
View reviewed changes
@tzarc tzarc force-pushed the hardware-id-serial-number branch from aee5994 to 6dcf09c Compare July 6, 2024 06:15
@tzarc tzarc force-pushed the hardware-id-serial-number branch from 6dcf09c to 47a0fc5 Compare July 6, 2024 06:16
@tzarc tzarc force-pushed the hardware-id-serial-number branch from 18f28a5 to 5c321a0 Compare July 17, 2024 23:12
@tzarc tzarc requested a review from a team July 17, 2024 23:14
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 18, 2024
@tzarc tzarc merged commit 305e7ba into qmk:develop Oct 6, 2024
4 checks passed
@tzarc tzarc deleted the hardware-id-serial-number branch October 6, 2024 08:44
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@tzarc @ilham-agustiawan
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
b96661d 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@tzarc @smallketchup82
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
31714b7 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@tzarc @jlaptavi
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
6992932 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@tzarc @DmNosachev
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
c1b513c 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@tzarc @SyrupSplashin
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
5770d16 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@tzarc @LeonMusCoden
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
c6753d4 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025
@tzarc @MichaelScofield45
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
a4257f7 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025
@tzarc @pashashocky
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
cbb3207 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@tzarc @Rumadon
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
0c36582 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@tzarc
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
4f85b3c 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@tzarc @alinelena
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
24e7008 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
artlugovoy pushed a commit to artlugovoy/qmk_firmware that referenced this pull request Feb 16, 2025
@tzarc @artlugovoy
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
2b1b5cb 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
srphcr pushed a commit to srphcr/qmk_firmware that referenced this pull request Mar 24, 2025
@tzarc @srphcr
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
5dc1813 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
oskar-wigstrom pushed a commit to oskar-wigstrom/qmk_firmware that referenced this pull request Apr 23, 2025
@tzarc @oskar-wigstrom
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
a64d718 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
minyu7374 pushed a commit to minyu7374/qmk_firmware that referenced this pull request Apr 25, 2025
@tzarc
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
4acb301 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@tzarc @MasayukiFukada
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
27549f6 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
w31mann pushed a commit to w31mann/qmk_firmware that referenced this pull request Aug 3, 2025
@tzarc
Allow for get_hardware_id() to be used for serial number. (qmk#24053)
0a56eea 
* Allow for `get_hardware_id()` to be used for serial number.

* Length checks.

* Explain length.

* Cleanup.

* Preprocessor magic.

* Use the force, Batman.

* Swap logic; if SERIAL_NUMBER is defined use that, otherwise derive it.

* Cleanup.

* Cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @drashna @zvecr