Skip to content

Segregrate keycode at pre-process record quantum #24194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2024
Merged

Segregrate keycode at pre-process record quantum #24194

merged 1 commit into from
Aug 26, 2024

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Jul 25, 2024 •
edited
Loading

Description

The previous implementation sends the same keycode variable to both pre_process_record_kb and process_combo. If changes are made to the record entry by pre_process_record_* functions that affect the keycode, it will not be reflected in the process_combo function.

This change ensures that the keycode variable in the process_combo function will be updated if modified.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 25, 2024
@drashna drashna requested a review from a team July 25, 2024 18:18
@filterpaper filterpaper force-pushed the segregate-pre-process-keycode branch from bbf2f6a to 80eb6e4 Compare July 26, 2024 02:03
@filterpaper
Segregrate keycode at pre-process record quantum
5d2d389 
The previous implementation sends the same keycode variable to both
pre_process_record_kb and process_combo. If changes are made to
the record entry by pre_process_record_* functions that affect the
keycode, it will not be reflected in the process_combo function.

This change ensures that the keycode variable in the process_combo
function will be updated if modified.
@filterpaper filterpaper force-pushed the segregate-pre-process-keycode branch from 80eb6e4 to 5d2d389 Compare July 26, 2024 02:14
@tzarc tzarc added the develop-fast-track Intended to be merged early in the next develop cycle. label Aug 12, 2024
@tzarc tzarc merged commit 11f2209 into qmk:develop Aug 26, 2024
4 checks passed
@filterpaper filterpaper deleted the segregate-pre-process-keycode branch August 26, 2024 00:29
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Sep 6, 2024
@filterpaper @waffle87
Segregrate keycode at pre-process record quantum (qmk#24194)
89bafdc
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Sep 6, 2024
@filterpaper @waffle87
Segregrate keycode at pre-process record quantum (qmk#24194)
378bc55
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 2, 2024
@filterpaper @itsme-zeix
Segregrate keycode at pre-process record quantum (qmk#24194)
94922c5
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@filterpaper @ilham-agustiawan
Segregrate keycode at pre-process record quantum (qmk#24194)
fc72501
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@filterpaper @smallketchup82
Segregrate keycode at pre-process record quantum (qmk#24194)
d024106
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@filterpaper @jlaptavi
Segregrate keycode at pre-process record quantum (qmk#24194)
b4e1bf3
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@filterpaper @DmNosachev
Segregrate keycode at pre-process record quantum (qmk#24194)
1366875
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@filterpaper @SyrupSplashin
Segregrate keycode at pre-process record quantum (qmk#24194)
52940b8
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@filterpaper @LeonMusCoden
Segregrate keycode at pre-process record quantum (qmk#24194)
47c95bc
MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025
@filterpaper @MichaelScofield45
Segregrate keycode at pre-process record quantum (qmk#24194)
7b2851b
pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025
@filterpaper @pashashocky
Segregrate keycode at pre-process record quantum (qmk#24194)
8025cc1
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@filterpaper @Rumadon
Segregrate keycode at pre-process record quantum (qmk#24194)
2967228
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@filterpaper
Segregrate keycode at pre-process record quantum (qmk#24194)
cf42c19
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@filterpaper @alinelena
Segregrate keycode at pre-process record quantum (qmk#24194)
1d67691
artlugovoy pushed a commit to artlugovoy/qmk_firmware that referenced this pull request Feb 16, 2025
@filterpaper @artlugovoy
Segregrate keycode at pre-process record quantum (qmk#24194)
525fa10
srphcr pushed a commit to srphcr/qmk_firmware that referenced this pull request Mar 24, 2025
@filterpaper @srphcr
Segregrate keycode at pre-process record quantum (qmk#24194)
f9c7137
oskar-wigstrom pushed a commit to oskar-wigstrom/qmk_firmware that referenced this pull request Apr 23, 2025
@filterpaper @oskar-wigstrom
Segregrate keycode at pre-process record quantum (qmk#24194)
d893f9e
minyu7374 pushed a commit to minyu7374/qmk_firmware that referenced this pull request Apr 25, 2025
@filterpaper
Segregrate keycode at pre-process record quantum (qmk#24194)
9fdfc2e
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@filterpaper @MasayukiFukada
Segregrate keycode at pre-process record quantum (qmk#24194)
2458ab6
w31mann pushed a commit to w31mann/qmk_firmware that referenced this pull request Aug 3, 2025
@filterpaper
Segregrate keycode at pre-process record quantum (qmk#24194)
dda20f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core develop-fast-track Intended to be merged early in the next develop cycle.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @tzarc