Skip to content

skyloong/gk61: Remove overriding of core keycode behaviour #24655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 28, 2024

Description

Keyboards should not override keycodes like TO(x) to behave like PDF(x).

Also,

  • Partially indicator logic as was dependent on overriding keycode behaviour
    • Also made bad assumptions on configuration of keymap which user changes can invalidate
  • Aligned implementations between the two pro revisions
  • Remove some unused defines

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna merged commit 68f67e2 into qmk:develop Dec 8, 2024
3 checks passed
@zvecr zvecr deleted the tidy_skyloong_gk61 branch December 8, 2024 20:33
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
johanbast pushed a commit to johanbast/qmk_firmware that referenced this pull request Feb 28, 2025
srphcr pushed a commit to srphcr/qmk_firmware that referenced this pull request Mar 24, 2025
vinniefranco pushed a commit to Good-Great-Grand-Wonderful/qmk_firmware that referenced this pull request Mar 30, 2025
oskar-wigstrom pushed a commit to oskar-wigstrom/qmk_firmware that referenced this pull request Apr 23, 2025
minyu7374 pushed a commit to minyu7374/qmk_firmware that referenced this pull request Apr 25, 2025
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
ChrisGVE pushed a commit to ChrisGVE/qmk_firmware that referenced this pull request May 6, 2025
ichichou pushed a commit to ichichou/qmk_firmware that referenced this pull request May 8, 2025
JoseCaliz pushed a commit to JoseCaliz/qmk_firmware that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants