Fix Quantum Painter compiliation issues with heavy optimization #24667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting `OPT = 3` or similar heavy optimization, errors out with `-Werror=maybe-uninitialized` on a number of variables. Initializing them should be harmless, as they're passed as pointers to other functions to be set, and fixes the errors without changing additional compiler options.
tzarc
approved these changes
Dec 2, 2024
alinelena
pushed a commit
to alinelena/qmk_firmware
that referenced
this pull request
Feb 3, 2025
johanbast
pushed a commit
to johanbast/qmk_firmware
that referenced
this pull request
Feb 28, 2025
srphcr
pushed a commit
to srphcr/qmk_firmware
that referenced
this pull request
Mar 24, 2025
vinniefranco
pushed a commit
to Good-Great-Grand-Wonderful/qmk_firmware
that referenced
this pull request
Mar 30, 2025
oskar-wigstrom
pushed a commit
to oskar-wigstrom/qmk_firmware
that referenced
this pull request
Apr 23, 2025
minyu7374
pushed a commit
to minyu7374/qmk_firmware
that referenced
this pull request
Apr 25, 2025
MasayukiFukada
pushed a commit
to MasayukiFukada/qmk_firmware
that referenced
this pull request
May 1, 2025
ChrisGVE
pushed a commit
to ChrisGVE/qmk_firmware
that referenced
this pull request
May 6, 2025
ichichou
pushed a commit
to ichichou/qmk_firmware
that referenced
this pull request
May 8, 2025
JoseCaliz
pushed a commit
to JoseCaliz/qmk_firmware
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title says. When setting
OPT = 3or similar heavy optimization, errors out with-Werror=maybe-uninitializedon a number of variables. Initializing them should be harmlesss, as they're passed as pointers to other functions to be set, and fixes the errors without changing additional compiler options.Types of Changes
Issues Fixed or Closed by This PR
Checklist