Skip to content

Subscript alef correction #24707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Subscript alef correction #24707

merged 1 commit into from
Dec 12, 2024

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Dec 12, 2024 •
edited
Loading

Description

Output for U+0656 is AltGr + V

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 12, 2024
zvecr
zvecr requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this header directly is incorrect.

data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson needs updating and util/regen.sh run.

@filterpaper
Subscript alef correction
830c7ef 
Output for U+0656 is AltGr + V
@github-actions github-actions bot added the dd Data Driven Changes label Dec 12, 2024
@filterpaper
Copy link
Contributor Author

Changing this header directly is incorrect.

data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson needs updating and util/regen.sh run.

It is updated as instructed.

@waffle87 waffle87 merged commit e1351b4 into qmk:develop Dec 12, 2024
5 checks passed
@filterpaper filterpaper deleted the farsi-correction branch December 12, 2024 19:32
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@filterpaper @alinelena
Subscript alef correction (qmk#24707)
4aca108 
Output for U+0656 is AltGr + V
johanbast pushed a commit to johanbast/qmk_firmware that referenced this pull request Feb 28, 2025
@filterpaper @johanbast
Subscript alef correction (qmk#24707)
dea43fc 
Output for U+0656 is AltGr + V
srphcr pushed a commit to srphcr/qmk_firmware that referenced this pull request Mar 24, 2025
@filterpaper @srphcr
Subscript alef correction (qmk#24707)
50d137d 
Output for U+0656 is AltGr + V
vinniefranco pushed a commit to Good-Great-Grand-Wonderful/qmk_firmware that referenced this pull request Mar 30, 2025
@filterpaper @vinniefranco
Subscript alef correction (qmk#24707)
3132d0f 
Output for U+0656 is AltGr + V
oskar-wigstrom pushed a commit to oskar-wigstrom/qmk_firmware that referenced this pull request Apr 23, 2025
@filterpaper @oskar-wigstrom
Subscript alef correction (qmk#24707)
df267fd 
Output for U+0656 is AltGr + V
minyu7374 pushed a commit to minyu7374/qmk_firmware that referenced this pull request Apr 25, 2025
@filterpaper
Subscript alef correction (qmk#24707)
f8b948e 
Output for U+0656 is AltGr + V
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@filterpaper @MasayukiFukada
Subscript alef correction (qmk#24707)
e75c42f 
Output for U+0656 is AltGr + V
ChrisGVE pushed a commit to ChrisGVE/qmk_firmware that referenced this pull request May 6, 2025
@filterpaper @ChrisGVE
Subscript alef correction (qmk#24707)
0e45ab0 
Output for U+0656 is AltGr + V
ichichou pushed a commit to ichichou/qmk_firmware that referenced this pull request May 8, 2025
@filterpaper @ichichou
Subscript alef correction (qmk#24707)
a60d7aa 
Output for U+0656 is AltGr + V
JoseCaliz pushed a commit to JoseCaliz/qmk_firmware that referenced this pull request Jun 3, 2025
@filterpaper @JoseCaliz
Subscript alef correction (qmk#24707)
0c46eab 
Output for U+0656 is AltGr + V
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
core dd Data Driven Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @zvecr @waffle87