Skip to content

Require 'x'/'y' properties for LED/RGB Matrix layout #24997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2025
Merged

Require 'x'/'y' properties for LED/RGB Matrix layout #24997

merged 1 commit into from
Mar 9, 2025
+2 −0

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 9, 2025 •
edited
Loading

Description

Spotted on 24994,

            {"matrix": [5, 4], "x": 44, "y": 32, "flags": 1},
            {"flags": 1}

Note: flags has not been made mandatory as we have existing keyboards which do not specify the property.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the dd Data Driven Changes label Mar 9, 2025
@zvecr zvecr merged commit 21c1fd5 into qmk:develop Mar 9, 2025
2 checks passed
@zvecr zvecr deleted the led_layout_require_xy branch March 9, 2025 23:41
clownfish-og pushed a commit to clownfish-og/qmk_firmware that referenced this pull request Apr 24, 2025
@zvecr @clownfish-og
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
abeed86
clownfish-og pushed a commit to clownfish-og/qmk_firmware that referenced this pull request Apr 29, 2025
@zvecr @clownfish-og
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
49dead3
ChrisGVE pushed a commit to ChrisGVE/qmk_firmware that referenced this pull request May 6, 2025
@zvecr @ChrisGVE
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
e903a96
JoseCaliz pushed a commit to JoseCaliz/qmk_firmware that referenced this pull request Jun 3, 2025
@zvecr @JoseCaliz
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
3be558e
faisyl pushed a commit to faisyl/qmk_firmware that referenced this pull request Jun 21, 2025
@zvecr @faisyl
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
4e08f92
srphcr pushed a commit to srphcr/qmk_firmware that referenced this pull request Jun 27, 2025
@zvecr @srphcr
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
933f2f0
Jari27 pushed a commit to Jari27/qmk_firmware that referenced this pull request Jul 3, 2025
@zvecr @Jari27
Require 'x'/'y' properties for LED/RGB Matrix layout (qmk#24997)
dd55d54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc