Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Clarify audio keycodes #4620

Merged
merged 5 commits into from Dec 14, 2018
Merged

Docs: Clarify audio keycodes #4620

merged 5 commits into from Dec 14, 2018

Conversation

drashna
Copy link
Member

@drashna drashna commented Dec 12, 2018 •
edited

Closes #4617 and closes #4619

noroadsleft
noroadsleft reviewed Dec 12, 2018
View reviewed changes
docs/feature_audio.md Outdated Show resolved Hide resolved
noroadsleft
noroadsleft reviewed Dec 12, 2018
View reviewed changes
docs/keycodes.md Outdated Show resolved Hide resolved
noroadsleft and others added 2 commits December 12, 2018 12:56
@noroadsleft @drashna
Spelling errors
6edcf0f 
Co-Authored-By: drashna <drashna@live.com>
@noroadsleft @drashna
Spacing in md
eb99721 
Co-Authored-By: drashna <drashna@live.com>
@jetpacktuxedo
Copy link
Contributor

Honestly, you could probably just say Toggles Audio given that MU_TOG just says Toggles Music Mode. This also works, though imo.

mechmerlin
mechmerlin approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mechmerlin mechmerlin merged commit 9739d6b into qmk:master Dec 14, 2018
@drashna drashna deleted the docs/audio_clarification branch December 14, 2018 18:46
ishtob pushed a commit to ishtob/qmk_firmware that referenced this pull request Jan 1, 2019
@drashna @ishtob
Docs: Clarify audio keycodes (qmk#4620)
69491c2 
* Clarify audio keycodes

* Spelling errors

Co-Authored-By: drashna <drashna@live.com>

* Spacing in md

Co-Authored-By: drashna <drashna@live.com>

* Fix midi link too

* Wordsmithing
yeliu84 pushed a commit to yeliu84/qmk_firmware that referenced this pull request Jan 7, 2019
@drashna @yeliu84
Docs: Clarify audio keycodes (qmk#4620)
a87bc8a 
* Clarify audio keycodes

* Spelling errors

Co-Authored-By: drashna <drashna@live.com>

* Spacing in md

Co-Authored-By: drashna <drashna@live.com>

* Fix midi link too

* Wordsmithing
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@drashna @rseymour
Docs: Clarify audio keycodes (qmk#4620)
b6b8e0d 
* Clarify audio keycodes

* Spelling errors

Co-Authored-By: drashna <drashna@live.com>

* Spacing in md

Co-Authored-By: drashna <drashna@live.com>

* Fix midi link too

* Wordsmithing
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
@drashna @djthread
Docs: Clarify audio keycodes (qmk#4620)
eb2fb16 
* Clarify audio keycodes

* Spelling errors

Co-Authored-By: drashna <drashna@live.com>

* Spacing in md

Co-Authored-By: drashna <drashna@live.com>

* Fix midi link too

* Wordsmithing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetpacktuxedo jetpacktuxedo jetpacktuxedo left review comments

@noroadsleft noroadsleft noroadsleft left review comments

@mechmerlin mechmerlin mechmerlin approved these changes

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio docs point to non-existant file for midi information AU_TOG description in the docs is misleading
4 participants
@drashna @jetpacktuxedo @noroadsleft @mechmerlin