Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of Laptreus Keyboard #4967

Merged
merged 11 commits into from Feb 6, 2019

Conversation

Projects
None yet
6 participants
@vosechu
Copy link
Contributor

vosechu commented Jan 27, 2019

WIP, please do not merge!

Initial commit of the Laptreus bluetooth keyboard.

Description

This adds the default, and a personal layout, as well as beginning on a doc for a debug layout.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@vosechu vosechu changed the title Initial commit of Laptreus Keyboard WIP: Initial commit of Laptreus Keyboard Jan 27, 2019

@vosechu

This comment has been minimized.

Copy link
Contributor Author

vosechu commented Jan 27, 2019

@drashna I would dearly love your thoughts on how I can make this better! I'm going to continue to iterate on some of the docs.

@vosechu vosechu force-pushed the vosechu:vosechu-laptreus branch from 70e8cb0 to 2cb9e33 Jan 27, 2019

@vosechu vosechu force-pushed the vosechu:vosechu-laptreus branch from 2cb9e33 to 032ff17 Jan 27, 2019

Show resolved Hide resolved keyboards/laptreus/config.h Outdated
Show resolved Hide resolved keyboards/laptreus/config.h Outdated
Show resolved Hide resolved keyboards/laptreus/config.h Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/debug/README.md Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/debug/config.h Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/default/keymap.c Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/default/rules.mk Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/vosechu/config.h Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/vosechu/keymap.c Outdated
Show resolved Hide resolved keyboards/laptreus/keymaps/vosechu/rules.mk Outdated
@vosechu

This comment has been minimized.

Copy link
Contributor Author

vosechu commented Jan 28, 2019

Lordy! I have a lot to learn about C!

Thank you so much for the review @drashna and @vomindoraan. I'll make these changes

@drashna

This comment has been minimized.

Copy link
Member

drashna commented Jan 28, 2019

There is always more to learn! :)

Also, there is a lot that QMK does "behind the scenes", that may not be obvious.
So, a lot of the review is just getting it to conform to what we're using currently.

If you have any questions, or need any help, don't hesitate to ask.

@mechmerlin mechmerlin added the keyboard label Jan 28, 2019

vosechu added some commits Jan 29, 2019

@vosechu

This comment has been minimized.

Copy link
Contributor Author

vosechu commented Jan 29, 2019

I still have a couple more changes to make, but I would greatly appreciate any feedback you all might have! @drashna @vomindoraan

Thank you!

TODO:

  • Flesh out readme for vosechu
  • Add comments from vosechu's keymap to default keymap
#define DEVICE_VER 0x0001
#define MANUFACTURER Vosechu
#define PRODUCT Laptreus
#define DESCRIPTION keyboard

This comment has been minimized.

Copy link
@drashna

drashna Jan 29, 2019

Member

This should probably be more descriptive. :)

It's not necessary, but ....

This comment has been minimized.

Copy link
@vosechu

vosechu Jan 30, 2019

Author Contributor

I totally agree! Let me try something out. When I had it longer the first time it made the USB menu obscenely long; like the whole description was there every time I clicked on the device! But that seems crazy and I'd like to try it again now that I've learned a bit more and gotten more comfortable with the board.

This comment has been minimized.

Copy link
@fauxpark

fauxpark Feb 1, 2019

Contributor

DESCRIPTION is only used in two places: the Command version info printout and the Adafruit BLE device name:

static const char kGapDevName[] PROGMEM =
"AT+GAPDEVNAME=" STR(PRODUCT) " " STR(DESCRIPTION);

IMO it probably shouldn't be there.

This comment has been minimized.

Copy link
@vosechu

vosechu Feb 2, 2019

Author Contributor

screen shot 2019-02-01 at 4 59 54 pm

Finally tested this out: I'm not sure how it gets there, but this is what's in my bluetooth bar. :/

@fauxpark Are you saying this is a bug in adafruit_ble.cpp? Or is there something I can do to fix this?

This comment has been minimized.

Copy link
@vosechu

vosechu Feb 2, 2019

Author Contributor

Nevermind! I see the ticket you created. Thank you @fauxpark!

@drashna

This comment has been minimized.

Copy link
Member

drashna commented Jan 29, 2019

Sounds good!

Also, for the debug layout, you may want to consider including something like this:

bool process_record_user(uint16_t keycode, keyrecord_t *record) {
// If console is enabled, it will print the matrix position and status of each key pressed
#ifdef KEYLOGGER_ENABLE
#if defined(KEYBOARD_ergodox_ez) || defined(KEYBOARD_iris_rev2)
xprintf("KL: col: %u, row: %u, pressed: %u\n", record->event.key.row, record->event.key.col, record->event.pressed);
#else
xprintf("KL: col: %u, row: %u, pressed: %u\n", record->event.key.col, record->event.key.row, record->event.pressed);
#endif
#endif //KEYLOGGER_ENABLE

If you have the CONSOLE enabled, it will output info to HID Listen (the QMK Toolbox, for instance), so you can see where it's typing at.

@drashna drashna added the in progress label Jan 30, 2019

tracyatrf and others added some commits Jan 31, 2019

Merge pull request #1 from tracyatrf/tracy-laptreus
Update connection auto detection logic

@fauxpark fauxpark referenced this pull request Feb 1, 2019

Merged

Remove keyboard description from Adafruit BLE device name #5028

4 of 13 tasks complete
@drashna

drashna approved these changes Feb 5, 2019

@drashna

This comment has been minimized.

Copy link
Member

drashna commented Feb 5, 2019

It looks like this is ready to go. Just wanted to make sure first.

@vosechu vosechu changed the title WIP: Initial commit of Laptreus Keyboard Initial commit of Laptreus Keyboard Feb 5, 2019

@vosechu

This comment has been minimized.

Copy link
Contributor Author

vosechu commented Feb 5, 2019

Thank you! Yes, let's ship it! Had a friend build the board and his own firmware, so we were able to sanity check it.

@drashna

This comment has been minimized.

Copy link
Member

drashna commented Feb 6, 2019

Awesome!

@drashna drashna merged commit a3104a7 into qmk:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@drashna drashna removed the in progress label Feb 6, 2019

deoxys314 added a commit to deoxys314/qmk_firmware that referenced this pull request Feb 7, 2019

[Keyboard] Initial commit of Laptreus Keyboard (qmk#4967)
* Add userspace files for vosechu

* Code review corrections

* Few more code review corrections

* Initial add of Laptreus code

* Initial add of Laptreus code

* Adding last punctuation to default

* Add some debug suggestions to the debug readme

* Fixes for PR feedback

* Fixing capitalization of readme files

* update auto detect connection logic

zer09 added a commit to zer09/qmk_firmware that referenced this pull request Feb 16, 2019

[Keyboard] Initial commit of Laptreus Keyboard (qmk#4967)
* Add userspace files for vosechu

* Code review corrections

* Few more code review corrections

* Initial add of Laptreus code

* Initial add of Laptreus code

* Adding last punctuation to default

* Add some debug suggestions to the debug readme

* Fixes for PR feedback

* Fixing capitalization of readme files

* update auto detect connection logic

deoxys314 added a commit to deoxys314/qmk_firmware that referenced this pull request Mar 2, 2019

[Keyboard] Initial commit of Laptreus Keyboard (qmk#4967)
* Add userspace files for vosechu

* Code review corrections

* Few more code review corrections

* Initial add of Laptreus code

* Initial add of Laptreus code

* Adding last punctuation to default

* Add some debug suggestions to the debug readme

* Fixes for PR feedback

* Fixing capitalization of readme files

* update auto detect connection logic

gavinenns added a commit to gavinenns/qmk_firmware that referenced this pull request Apr 7, 2019

[Keyboard] Initial commit of Laptreus Keyboard (qmk#4967)
* Add userspace files for vosechu

* Code review corrections

* Few more code review corrections

* Initial add of Laptreus code

* Initial add of Laptreus code

* Adding last punctuation to default

* Add some debug suggestions to the debug readme

* Fixes for PR feedback

* Fixing capitalization of readme files

* update auto detect connection logic

@vosechu vosechu deleted the vosechu:vosechu-laptreus branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.