Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tx Bolt ghosting second character on key press #5229

Merged
merged 2 commits into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@tschulte
Copy link
Contributor

commented Feb 23, 2019

Description

Fix missing break; in switch statement.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tschulte added some commits Feb 22, 2019

fix #4578: don't call gemini protocol code when in bolt mode
Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

@drashna drashna added bug core and removed core labels Feb 24, 2019

@drashna

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

Thanks!

@drashna drashna merged commit a69e440 into qmk:master Feb 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ayatk added a commit to ayatk/qmk_firmware that referenced this pull request Feb 25, 2019

Merge branch 'master' into helix/ayatk
* master: (237 commits)
  Fix indentation in quantum_keycodes.h (qmk#5221)
  [Keymap] Initial upload of stanrc85 HS60 v2 layout and config (qmk#5217)
  [Keymap] Added a key to handle copy/paste in and out of a terminal (qmk#5205)
  Fix Tx Bolt ghosting second character on key press (qmk#5229)
  Clueboard 66% Hotswap Support (qmk#5204)
  removed old keymaps (qmk#5227)
  Keymap: Update Koba's keymap for Ergo42. (qmk#5223)
  Update readme.md (qmk#5230)
  edit the readme to mention the NYM96 since it's the same PCB and is currently on sale at Massdrop
  Jotix keymaps (qmk#5203)
  Candybar: remove mousekeys as default (qmk#5210)
  Jotpad16 (qmk#5212)
  fix rgblight_effect_breathing interval time (qmk#5213)
  Replace instances of KEYMAP with LAYOUT
  [Keymap] Added preonic and mechmini 2 keymaps (qmk#5202)
  Grammar cleanup of Flashing Your Keyboard Newbs Guide (qmk#5201)
  [Keyboard] add jotanck keyboard (qmk#5192)
  Velocikey: Match RGB animation speed to typing speed (qmk#3754)
  Updated hand wiring docs (qmk#5198)
  Reduce tetris firmware size by disabling default audio (qmk#5197)
  ...

@tschulte tschulte deleted the tschulte:fixTxBolt branch Mar 1, 2019

HokieGeek added a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

slugger7 added a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

sriehl added a commit to sriehl/qmk_firmware that referenced this pull request Mar 15, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

zer09 added a commit to zer09/qmk_firmware that referenced this pull request Mar 18, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

chie4hao added a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

slugger7 added a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

gavinenns added a commit to gavinenns/qmk_firmware that referenced this pull request Apr 7, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.

dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019

Fix Tx Bolt ghosting second character on key press (qmk#5229)
* convert tabs to spaces

* fix qmk#4578: don't call gemini protocol code when in bolt mode

Add missing break; statements in switch. The missing break resulted in
a fall through and an additional processing of the gemini code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.