Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tap/down/up handling in dynamic keymap macros #5363

Merged
merged 2 commits into from Apr 8, 2019

Conversation

wilba
Copy link
Contributor

@wilba wilba commented Mar 11, 2019

Description

Fixed tap/down/up handling in dynamic keymap macros

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

@yanfali
Copy link
Contributor

yanfali commented Mar 11, 2019

@drashna agree this looks great. Maybe we should export TAP, DOWN and UP defines somewhere so the values can be shared instead of just knowing 1 is tap, 2 is down and 3 is up. quantum.c has almost the same code in both functions send_string_with_delay{_p}. They differ by 1 line.

@wilba
Copy link
Contributor Author

wilba commented Mar 30, 2019

@yanfali @drashna I have made the suggested changes.

@wilba
Copy link
Contributor Author

wilba commented Apr 4, 2019

ne merge avail?

@drashna drashna merged commit 908966b into qmk:master Apr 8, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* Fixed tap/down/up handling in dynamic keymap macros

* Added SS_TAP_CODE, SS_DOWN_CODE, SS_UP_CODE
@wilba wilba deleted the macro_fix branch March 23, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants