Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runner3680 #6069

Merged
merged 2 commits into from Jun 6, 2019
Merged

add runner3680 #6069

merged 2 commits into from Jun 6, 2019

Conversation

omkbd
Copy link
Contributor

@omkbd omkbd commented Jun 4, 2019

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • add runner3680 keyboard

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jun 4, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bunch of minor cleanup that can be done.

If you need any help with this, just let us know.

keyboards/runner3680/3x6/3x6.h Outdated Show resolved Hide resolved
keyboards/runner3680/3x6/3x6.h Outdated Show resolved Hide resolved
keyboards/runner3680/3x6/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/3x6/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/3x6/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/5x7/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/5x8/keymaps/JIS/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/5x8/keymaps/JIS/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/5x8/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/runner3680/5x8/keymaps/default/keymap.c Outdated Show resolved Hide resolved
drashna
drashna approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@drashna drashna merged commit 872480d into qmk:master Jun 6, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@omkbd @Timbus
[Keyboard] add runner3680 keyboards (qmk#6069)
0fa7282 
* add runner3680

* Remove unnecessary code
@omkbd omkbd deleted the dev_branch branch July 10, 2019 17:57
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@omkbd @doughsay
[Keyboard] add runner3680 keyboards (qmk#6069)
0781fd6 
* add runner3680

* Remove unnecessary code
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@omkbd @drashna
[Keyboard] add runner3680 keyboards (qmk#6069)
725427c 
* add runner3680

* Remove unnecessary code
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@omkbd @JeffreyPalmer
[Keyboard] add runner3680 keyboards (qmk#6069)
a7b3e92 
* add runner3680

* Remove unnecessary code
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@omkbd @swamp09
[Keyboard] add runner3680 keyboards (qmk#6069)
0462041 
* add runner3680

* Remove unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omkbd @drashna @fauxpark @mechmerlin