Jump to conversation
Unresolved conversations (2)
@noroadsleft noroadsleft May 3, 2020
Have never known `#pragma once` to be used in a `.c` file :confused:
Outdated
keyboards/lily58/lib/glcdfont_lily.c
noroadsleft rhruiz
yyc
@rhruiz rhruiz Apr 21, 2020
hey @yyc this workaround came in the rebase/merge and maybe is no longer required when using common split code?
Outdated
keyboards/lily58/rules.mk
drashna
Resolved conversations (20)
@fauxpark fauxpark May 3, 2020
```suggestion ```
Outdated
keyboards/lily58/keymaps/chuan/rules.mk
@fauxpark fauxpark May 3, 2020
```suggestion EXTRAKEY_ENABLE = yes NKRO_ENABLE = yes ENCODER_ENABLE = yes ``` *edited for formatting - noroadsleft*
Outdated
keyboards/lily58/keymaps/chuan/rules.mk
@fauxpark fauxpark May 3, 2020
```suggestion #include "timer.h" ```
Outdated
keyboards/lily58/lib/timelogger.c
@fauxpark fauxpark May 3, 2020
```suggestion void encoder_update_user(uint8_t index, bool clockwise) { lastIndex = index; if (clockwise) { counter++; tap_code(KC_PGDN); } else { counter--; tap_code(KC_PGUP); } } ```
Outdated
keyboards/lily58/keymaps/chuan/keymap.c
@fauxpark fauxpark May 3, 2020
```suggestion ```
Outdated
keyboards/lily58/lib/glcdfont_lily.c
@fauxpark fauxpark May 3, 2020
```suggestion #include "led.h" #include "host.h" ```
Outdated
keyboards/lily58/lib/host_led_state_reader.c
@fauxpark fauxpark May 3, 2020
```suggestion #include "action.h" ```
Outdated
keyboards/lily58/lib/keylogger.c
@fauxpark fauxpark May 3, 2020
```suggestion OLED_DRIVER_ENABLE = yes # OLED display SPLIT_KEYBOARD = yes ```
Outdated
keyboards/lily58/rules.mk
@fauxpark fauxpark May 3, 2020
```suggestion ```
Outdated
keyboards/lily58/rules.mk
@drashna drashna Apr 28, 2020
```suggestion #pragma once ```
Outdated
keyboards/lily58/lib/glcdfont_lily.c
@drashna drashna Apr 28, 2020
This may not be needed, if you use the rgblight "get" functions. https://docs.qmk.fm/#/feature_rgblight?id=query
keyboards/lily58/keymaps/chuan/keymap.c
yyc
@drashna drashna Apr 28, 2020
This block isn't needed. ```suggestion ```
Outdated
keyboards/lily58/keymaps/chuan/keymap.c
@rhruiz rhruiz Apr 21, 2020
this was removed on the master, now in this branch this `#ifndef` has no `#endif`
Outdated
keyboards/lily58/lib/glcdfont_lily.c
@fauxpark fauxpark Sep 22, 2019
The backslashes at the end of these lines are not necessary. You can keep them if you want as it isn't hurting anything, but IMO it looks neater without them.
Outdated
keyboards/lily58/keymaps/chuan/keymap.c
@fauxpark fauxpark Sep 22, 2019
```suggestion ``` QMK calculates this on its own, now.
Outdated
keyboards/lily58/keymaps/chuan/config.h
@fauxpark fauxpark Aug 8, 2019
```suggestion #define L_LOWER (1 << 1) ```
Outdated
keyboards/lily58/lib/layer_state_reader.c
@fauxpark fauxpark Aug 8, 2019
```suggestion #define L_RAISE (1 << 2) ```
Outdated
keyboards/lily58/lib/layer_state_reader.c
@fauxpark fauxpark Aug 8, 2019
```suggestion #define L_ADJUST_TRI (L_ADJUST | L_RAISE | L_LOWER) ```
Outdated
keyboards/lily58/lib/layer_state_reader.c
@fauxpark fauxpark Aug 8, 2019
```suggestion #define L_ADJUST (1 << 16) ```
Outdated
keyboards/lily58/lib/layer_state_reader.c
fauxpark
@drashna drashna Jul 6, 2019
The stuff from the serial_config.h file should be moved into this file, and that file removed.
Outdated
keyboards/lily58/config.h
yyc