Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sm68 #7279

Merged
merged 12 commits into from Nov 11, 2019

Conversation

@hineybush
Copy link
Contributor

hineybush commented Nov 6, 2019

Description

Add new PCB for 68-key layouts

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
hineybush added 2 commits Nov 4, 2019
hineybush
@drashna
drashna approved these changes Nov 6, 2019
Copy link
Member

drashna left a comment

Looks great!

@drashna drashna requested a review from qmk/collaborators Nov 6, 2019
@drashna drashna added the keyboard label Nov 6, 2019
@drashna drashna requested a review from noroadsleft Nov 6, 2019
@drashna

This comment has been minimized.

Copy link
Member

drashna commented Nov 6, 2019

Also, if you want to re-enable stuff, adding LTO_ENABLE = yes to the rules.mk may be a better way to regain space.

@hineybush

This comment has been minimized.

Copy link
Contributor Author

hineybush commented Nov 6, 2019

Also, if you want to re-enable stuff, adding LTO_ENABLE = yes to the rules.mk may be a better way to regain space.

Thanks. I don't see much of a need for the stuff I disabled for normal use, but maybe that will change down the line!

@hineybush hineybush closed this Nov 6, 2019
@hineybush hineybush reopened this Nov 6, 2019
@hineybush hineybush closed this Nov 6, 2019
@hineybush hineybush reopened this Nov 6, 2019
@hineybush

This comment has been minimized.

Copy link
Contributor Author

hineybush commented Nov 6, 2019

i need to stop hitting "close"....

keyboards/hineybush/sm68/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/sm68/readme.md Outdated Show resolved Hide resolved
keyboards/hineybush/sm68/rules.mk Outdated Show resolved Hide resolved
@noroadsleft

This comment has been minimized.

Copy link
Member

noroadsleft commented Nov 6, 2019

Need a git push here?

@hineybush

This comment has been minimized.

Copy link
Contributor Author

hineybush commented Nov 6, 2019

Need a git push here?

haven't had a chance to update the .json, will do later tonight!

keyboards/hineybush/sm68/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hineybush/sm68/readme.md Outdated Show resolved Hide resolved
keyboards/hineybush/sm68/sm68.h Outdated Show resolved Hide resolved
hineybush added 5 commits Nov 7, 2019
hineybush
hineybush
hineybush
hineybush
hineybush
hineybush
keyboards/hineybush/sm68/info.json Outdated Show resolved Hide resolved
keyboards/hineybush/sm68/info.json Outdated Show resolved Hide resolved
hineybush and others added 2 commits Nov 8, 2019
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: fauxpark <fauxpark@gmail.com>
Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>
Copy link
Member

noroadsleft left a comment

Everything here looks good except for the readme photo, but if that needs to come later, that's fine.

@hineybush

This comment has been minimized.

Copy link
Contributor Author

hineybush commented Nov 10, 2019

Everything here looks good except for the readme photo, but if that needs to come later, that's fine.

yeah that will be a few weeks down the line.

@drashna

This comment has been minimized.

Copy link
Member

drashna commented Nov 10, 2019

yeah that will be a few weeks down the line.

Could you replace the image line with "TBA" or the like, so it's obvious that it's intentional, rather than missing it?

hineybush
@hineybush

This comment has been minimized.

Copy link
Contributor Author

hineybush commented Nov 11, 2019

yeah that will be a few weeks down the line.

Could you replace the image line with "TBA" or the like, so it's obvious that it's intentional, rather than missing it?

done!

@noroadsleft

This comment has been minimized.

Copy link
Member

noroadsleft commented Nov 11, 2019

Thanks!

@noroadsleft noroadsleft merged commit 543e612 into qmk:master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
nickgartmann added a commit to nickgartmann/qmk_firmware that referenced this pull request Nov 12, 2019
* add sm68

* update rules.mk to decrease final size (hopefully)

* update rules.mk

* update json

* update per PR comments

* remove custom keycodes from keymap

* update layout names in keymap

* change layout names

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update readme
antolu added a commit to antolu/qmk_firmware that referenced this pull request Nov 13, 2019
* add sm68

* update rules.mk to decrease final size (hopefully)

* update rules.mk

* update json

* update per PR comments

* remove custom keycodes from keymap

* update layout names in keymap

* change layout names

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update readme
tomwang2011 pushed a commit to tomwang2011/qmk_firmware that referenced this pull request Nov 29, 2019
* add sm68

* update rules.mk to decrease final size (hopefully)

* update rules.mk

* update json

* update per PR comments

* remove custom keycodes from keymap

* update layout names in keymap

* change layout names

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update readme
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
* add sm68

* update rules.mk to decrease final size (hopefully)

* update rules.mk

* update json

* update per PR comments

* remove custom keycodes from keymap

* update layout names in keymap

* change layout names

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: fauxpark <fauxpark@gmail.com>

* Update keyboards/hineybush/sm68/info.json

Co-Authored-By: James Young <18669334+noroadsleft@users.noreply.github.com>

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.