Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[Feature] Secondary RGB configuration (incomplete - need feedback) #7919
When working on RGB effects I realised the current effects library would benefit from an additional dimension of configuration. For example:
Note: This branch is currently a proof-of-concept of this idea, it is NOT FINISHED.
This branch introduces a new type
The alt config has zero defined for all values by default, and in general operates by applying an offset to values in effects, thereby having no effect unless the users changes the values from zero. I have implemented the following effects:
If the concept of this feature is suitable for inclusion I will do the work to implement the alt config in other effects where applicable, however aside from missing effects & documentation there are a few other issues:
At this point I'm going to wait for further feedback before progressing more with this branch, but I request that the maintainers try it out. Thanks.
Types of Changes
@drashna definitely similar goals, but different. #5851 seems to be designed to allow a different lighting effect for different LED types, and certainly my branch also lets you do the same thing for some effects - e.g. the solid, gradient and cycle lets you configure the underglow differently.
However the main goal of my branch is to provide a secondary configuration dimension, which some effects would let you configure the underglow for, but not all. For example I intend to allow the reactive effects (simple, cross, nexus) to have alt configs which set a solid or gradient background to be combined with the reactive effects.
With respect to #5851, my branch conflicts with it but the features are probably mergeable, it would need the alt config threading through all the effects. That does seem to be stale however.
Anyway, let me know where you want to go next. I could create the reactive alt configs so you can see how that work would in practice? Or if you don't feel like you want this feature I will stop working on it
@drashna I'm not intending to address all regions, in the same way that the current RGB matrix effects do not address all regions. I'm proposing that each effect have a 2nd axis of configuration - for some effects this would control the underglow, in other effects it would be something different (such as a background colour for nexus/reactive). The different effects could make artistic choices about what the secondary configuration controls.
I feel like you are confusing the intention of this with that of the other PR you mentioned, which definitely does want to offer precise control over each region.
Thank you for your contribution!
Hi @drashna, just picking this up again.
I feel like last time we spoke you didn't grasp my description of how this is different to other branches, but that's not to say that I think it deserves to be in the main codebase. I have implemented this feature in my own keymap and effects for my personal use, so I have no special desire for it to be included. If you feel like this doesn't belong in the codebase I am happy to close this PR.
Let me know your thoughts.