Various tidyups for USB descriptor code #9005
Merged
+80
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
May 19, 2020
tzarc
approved these changes
May 19, 2020
fauxpark
force-pushed
the
misc-usb-descriptor-cleanups
branch
from
ca61f07 to
e5cb1e3
Compare
fauxpark
force-pushed
the
misc-usb-descriptor-cleanups
branch
from
e5cb1e3 to
2355b64
Compare
noroadsleft
pushed a commit
that referenced
this pull request
Jun 20, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 10, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 18, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 26, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Jul 31, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Aug 11, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Aug 27, 2020
noroadsleft
pushed a commit
that referenced
this pull request
Aug 29, 2020
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Sep 30, 2020
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
keyboard_led_statsin lufa.c and ChibiOS usb_main.c tokeyboard_led_state, as well asvusb_keyboard_leds, for consistencyENDPOINT_CONFIGmacro, it seems pointless and removes the need for endpoint address defines in the middle of the endpoint numbering enumGET_REPORTrequest handling. Not sure about this one, but the existing code appears to always return an empty report - nowsend_keyboardsets this variable to the current report, matching what the LUFA code does.Types of Changes
Issues Fixed or Closed by This PR
Checklist