Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Key 65 #9116

Merged
merged 14 commits into from May 26, 2020
Merged

Add Key 65 #9116

merged 14 commits into from May 26, 2020

Conversation

MxBlu
Copy link
Contributor

@MxBlu MxBlu commented May 17, 2020 •
edited

Adds Key 65 Universal and Hotswap PCBs. As I only own a universal PCB, hotswap is untested, but made against the KBFirmware JSON provided on the Geekhack thread.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@MxBlu MxBlu mentioned this pull request May 17, 2020
Closed
6 tasks
@fauxpark fauxpark requested a review from a team May 17, 2020 23:21
@fauxpark fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels May 17, 2020
@1ps3 1ps3 mentioned this pull request May 18, 2020
Merged
6 tasks
noroadsleft
noroadsleft requested changes May 18, 2020
View reviewed changes
keyboards/foxlab/key65/hotswap/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/foxlab/key65/hotswap/readme.md Outdated Show resolved Hide resolved
keyboards/foxlab/key65/hotswap/readme.md Outdated Show resolved Hide resolved
keyboards/foxlab/key65/hotswap/rules.mk Outdated Show resolved Hide resolved
keyboards/foxlab/key65/hotswap/config.h Outdated Show resolved Hide resolved
keyboards/foxlab/key65/universal/rules.mk Outdated Show resolved Hide resolved
keyboards/foxlab/key65/universal/universal.h Outdated Show resolved Hide resolved
keyboards/foxlab/key65/universal/universal.h Outdated Show resolved Hide resolved
keyboards/foxlab/key65/universal/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/key65/universal/info.json Outdated Show resolved Hide resolved
MxBlu and others added 6 commits May 18, 2020 19:55
@MxBlu @noroadsleft
Update keyboards/foxlab/key65/hotswap/config.h
77d3965 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@MxBlu @noroadsleft
Apply suggestions from code review
1a1d279 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@MxBlu
Invert capslock LED state
69c4712
@MxBlu
Avoid initial capslock LED flash
8a8849a
@MxBlu @noroadsleft
Apply suggestions from code review
812eba6 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@MxBlu
Update rules.mk
cc1e7b4
noroadsleft
noroadsleft requested changes May 22, 2020
View reviewed changes
keyboards/foxlab/key65/universal/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/key65/universal/info.json Show resolved Hide resolved
keyboards/foxlab/key65/universal/info.json Outdated Show resolved Hide resolved
@MxBlu @noroadsleft
Apply suggestions from code review
28c5949 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@drashna drashna requested a review from a team May 25, 2020 03:55
@noroadsleft noroadsleft merged commit 9d41281 into qmk:master May 26, 2020
@noroadsleft
Copy link
Member

Thanks!

sevanteri pushed a commit to sevanteri/qmk_firmware that referenced this pull request May 26, 2020
@MxBlu @sevanteri
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
588aacf 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
cmaier pushed a commit to cmaier/qmk_firmware that referenced this pull request May 27, 2020
@MxBlu @cmaier
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
7b69de2 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
Merge remote-tracking branch 'upstream/master'
f4d346a 
* upstream/master: (800 commits)
  Fix crkbd slave matrix print to require debug_matrix (qmk#9217)
  Keyboards/zsa updates (qmk#9214)
  Community layout support for KBDpad Mk.I (qmk#9220)
  Fix projectkb/alice LED indicator (qmk#9226)
  RSTHD keymap for Minidox (qmk#9178)
  Fix running qmk info without any arguments (qmk#9218)
  [Keymap] Update yttyx Planck keymap (qmk#9191)
  Documentation for keymap_extras (qmk#9194)
  Adding TGR Tris/Tris CE Numpad (qmk#9139)
  ISSI driver compile error fix (qmk#9169)
  Fix the path for generated keymaps (qmk#9213)
  Fix compiling json files (qmk#9210)
  [CLI] Add a subcommand for getting information about a keyboard (qmk#8666)
  [Keymap] Contributing Home-Row-Centric-Mousekey  Layout (qmk#9195)
  CLI: fix `json2c` subcommand and add/fix tests (qmk#9206)
  [Keymap] Ported ok60 to via (qmk#9179)
  [Docs] Japanese translation of docs/feature_pointing_device.md (qmk#8993)
  [Keymap] Niu keymap and README update (qmk#9190)
  [Keyboard] Add Key 65 by Fox Lab (qmk#9116)
  [Keymap] update helix/rev2:yshrsmz keymap (qmk#9047)
  ...
wavemoran pushed a commit to wavemoran/qmk_firmware that referenced this pull request Jun 12, 2020
@MxBlu @wavemoran
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
52e9045 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@MxBlu @turky
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
78884a8 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Jun 24, 2020
@MxBlu @tacahiroy
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
6c71386 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@MxBlu @jakobaa
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
865da7c 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
tomswartz07 pushed a commit to tomswartz07/qmk_firmware that referenced this pull request Aug 5, 2020
@MxBlu @tomswartz07
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
37cdf8a 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
hegelocampus pushed a commit to hegelocampus/qmk_firmware that referenced this pull request Aug 16, 2020
@MxBlu @hegelocampus
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
2f5797c 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
ea2809 pushed a commit to ea2809/qmk_firmware that referenced this pull request Oct 25, 2020
@MxBlu
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
fa632dc 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
lmiceli pushed a commit to lmiceli/qmk_firmware that referenced this pull request Dec 30, 2020
@MxBlu
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
029dfaa 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Jan 17, 2021
@MxBlu @sowbug
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
993a67f 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@MxBlu @sjmacneil
[Keyboard] Add Key 65 by Fox Lab (qmk#9116)
b31cee6 
* Add Key65 Universal PCB

* Add ISO layout to universal

* Correct universal info.json

* Add Key 65 Hotswap

* Correct typo in Key 65 Universal

* Update readmes

* Correct name

* Update keyboards/foxlab/key65/hotswap/config.h

* Apply suggestions from code review

* Invert capslock LED state

* Avoid initial capslock LED flash

* Apply suggestions from code review

* Update rules.mk

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MxBlu @noroadsleft @drashna @fauxpark