Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hsv->rgb conversion without using CIE curve. #9856

Merged
merged 2 commits into from Aug 5, 2020
Merged

Add support for hsv->rgb conversion without using CIE curve. #9856

merged 2 commits into from Aug 5, 2020

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 28, 2020

Description

As preparation for the new drawing APIs, I need to add support for HSV -> RGB conversions but disregard the CIE curve when doing so.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 28, 2020 20:20
@tzarc tzarc force-pushed the hsv_nocie branch 2 times, most recently from 452a9a2 to 74617ab Compare July 28, 2020 20:41
noroadsleft
noroadsleft approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna drashna requested a review from a team August 5, 2020 03:51
@tzarc tzarc merged commit c9236db into qmk:develop Aug 5, 2020
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
@tzarc @noroadsleft
Add support for hsv->rgb conversion without using CIE curve. (#9856)
7de0f17 
* Add support for hsv->rgb conversion without using CIE curve.

* Modify anavi/macropad8 to disable unicode (was unused), otherwise firmware size is too large.
@tzarc tzarc deleted the hsv_nocie branch August 22, 2020 09:23
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
@tzarc @noroadsleft
Add support for hsv->rgb conversion without using CIE curve. (#9856)
c99dd75 
* Add support for hsv->rgb conversion without using CIE curve.

* Modify anavi/macropad8 to disable unicode (was unused), otherwise firmware size is too large.
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
@tzarc @noroadsleft
Add support for hsv->rgb conversion without using CIE curve. (#9856)
c990dc1 
* Add support for hsv->rgb conversion without using CIE curve.

* Modify anavi/macropad8 to disable unicode (was unused), otherwise firmware size is too large.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@tzarc @nicocesar
Add support for hsv->rgb conversion without using CIE curve. (qmk#9856)
71f6dc3 
* Add support for hsv->rgb conversion without using CIE curve.

* Modify anavi/macropad8 to disable unicode (was unused), otherwise firmware size is too large.
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
@tzarc @drashna
Add support for hsv->rgb conversion without using CIE curve. (qmk#9856)
28947d5 
* Add support for hsv->rgb conversion without using CIE curve.

* Modify anavi/macropad8 to disable unicode (was unused), otherwise firmware size is too large.
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@tzarc @noroadsleft
Add support for hsv->rgb conversion without using CIE curve. (qmk#9856)
885e79f 
* Add support for hsv->rgb conversion without using CIE curve.

* Modify anavi/macropad8 to disable unicode (was unused), otherwise firmware size is too large.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzarc @drashna @noroadsleft