Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Qt Quick Controls 2.0 chapter [WIP] #203
Not sure what kind of review you're after at this stage... probably more high-level, I guess, but I pointed out some grammar issues just in case.
I think it looks fine.
Some other things that may be worth mentioning when you get to the content stage:
I just pushed a final draft. I've not incorporated @mitchcurtis 's comments above - will do so tomorrow. As you can see, the Documentation Window section does not work. I'm considering dropping it for now and reporting a bug on Qt (at least the dialog issues is a bug - the rest has to be fixed in the example).
@mitchcurtis - thank you for all your review comments. I believe that I've addressed all of them (some with comments). The only discussion that I'm not sure if we can close is the one about using QtQuick.Dialogs before Qt.labs.platform. The text explains why, but it does introduce a Qt Quick Controls 1 dependency, to avoid a QtWidgets dependency.
My proposal is that we merge this as a version 1.0 and improve it later on.
I propose is that we insert this as a new chapter 7, i.e. after Model-View-Delegate but before Canvas Element. The chapter does use models and views, so the order makes sense. It also uses dynamic element instantiations (chapter 13) but I think that we have to treat that as an advanced topic.
Do you agree?