Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when giving integer values to fchl kernel functions #110

Open
larsbratholm opened this issue Mar 15, 2019 · 0 comments
Open

Issue when giving integer values to fchl kernel functions #110

larsbratholm opened this issue Mar 15, 2019 · 0 comments

Comments

@larsbratholm
Copy link
Collaborator

There's a bug in the fchl kernel functions if some parameters are integers. E.g. https://github.com/qmlcode/qml/blob/develop/qml/fchl/fchl_kernel_functions.py#L38

The numpy array will be an integer array and the subsequent transformations will be rounded to integer values. To fix, the line above should explicitely have dtype=float added. There might be more similar cases in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant