From 47b8b9bbf599e68546de41af6619ce709a148578 Mon Sep 17 00:00:00 2001 From: Vincent Scavinner Date: Mon, 15 Jan 2024 21:28:26 +0100 Subject: [PATCH] fix(typing): positional argument should extends Array --- ember-autofocus-modifier/src/modifiers/autofocus.ts | 2 +- test-app/tests/integration/modifiers/autofocus-test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ember-autofocus-modifier/src/modifiers/autofocus.ts b/ember-autofocus-modifier/src/modifiers/autofocus.ts index e98d798d..413ccf51 100644 --- a/ember-autofocus-modifier/src/modifiers/autofocus.ts +++ b/ember-autofocus-modifier/src/modifiers/autofocus.ts @@ -16,7 +16,7 @@ const DEFAULT_SELECTOR = interface ModifierArgs { Element: HTMLElement; Args: { - Positional: [string?] | undefined; // Optional selector + Positional: [string?]; // Optional selector Named: { disabled?: boolean; // Optional 'disabled' parameter }; diff --git a/test-app/tests/integration/modifiers/autofocus-test.ts b/test-app/tests/integration/modifiers/autofocus-test.ts index 087845b0..e53ed3dd 100644 --- a/test-app/tests/integration/modifiers/autofocus-test.ts +++ b/test-app/tests/integration/modifiers/autofocus-test.ts @@ -181,7 +181,7 @@ module('Integration | Modifier | autofocus', function (hooks) { test('should not focus due to disabled parameter set to true without providing a selector', async function (assert) { await render(hbs` -
+
this is not a focusable element @@ -206,7 +206,7 @@ module('Integration | Modifier | autofocus', function (hooks) { test('should focus due to disabled parameter set to false', async function (assert) { await render(hbs` -
+
this is not a focusable element