New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-decorators dependency #20

Merged
merged 3 commits into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@kiwiupover
Copy link
Contributor

kiwiupover commented Feb 8, 2019

Remove the decorators from the phone-input component
updated super
adding input type

http://phone-input.surge.sh -> use this branch
http://phone-input-broken.surge.sh -> uses 2.0.5

The above app can be found here
https://github.com/kiwiupover/phone-input
https://github.com/kiwiupover/phone-input/tree/broken

@kiwiupover kiwiupover changed the title Decorators not transpiling for IE11 [Investigation] Decorators not transpiling for IE11 Feb 8, 2019

@kiwiupover

This comment has been minimized.

Copy link
Contributor Author

kiwiupover commented Feb 8, 2019

@dcyriller

This comment has been minimized.

Copy link
Contributor

dcyriller commented Feb 9, 2019

@kiwiupover thank you for the reproduction. I'll be able to check it out on Monday, I don't have IE 11 at home.

I'd be interested to know the root cause of this transpilation issue. Do you have an idea?

@dcyriller dcyriller added the bug label Feb 9, 2019

@jacojoubert

This comment has been minimized.

Copy link
Contributor

jacojoubert commented Feb 15, 2019

The issue was fixed by adding https://github.com/pzuraq/ember-cli-babel-polyfills which properly compiles the decorators to something IE11 can understand.

kiwiupover and others added some commits Feb 8, 2019

Complete decorators removal
Additionnaly, revert native Promise to RSVP's

@dcyriller dcyriller force-pushed the kiwiupover:remove-decorators branch from 1c093aa to 0ea7f2f Feb 15, 2019

@dcyriller

This comment has been minimized.

Copy link
Contributor

dcyriller commented Feb 15, 2019

Good to know @jacojoubert.

I want to procede with the decorator removal. To do so, I've added two commits.

@kiwiupover I've rebased the PR, thank you for your work.

@dcyriller dcyriller changed the title [Investigation] Decorators not transpiling for IE11 Remove ember-decorators dependency Feb 15, 2019

@dcyriller dcyriller merged commit f817997 into qonto:master Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment