Improve bats tests #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dverite
commented
Jul 15, 2025
dverite
commented
- don't use the hardcoded "unittest" db name (dangerous in local tests)
- fix generation of random table names
- clean up the dozen of yaml files left by each run
Fixes an issue with: cat /dev/urandom | head -n 1 | base64 | ... When a linefeed character appears in the first few random bytes, the string is too short, and may conflict with other generated short names (actually seen on some invocations of make bats-test...) Use `head -c 12 /dev/urandom` instead, and move it to a dedicated function. Signed-off-by: Daniel Vérité <dverite@gmail.com>
Signed-off-by: Daniel Vérité <dverite@gmail.com>
…est" Previously if a database named "unittest" pre-existed, it was dropped and recreated unconditionally. Now the tests generate a random database name, and use the environment variable PPM_DATABASE to refer to it. Additionally, PGDATABASE is used for the partition manager instead of a hardcoded URL in the template file. Signed-off-by: Daniel Vérité <dverite@gmail.com>
Collaborator
Author
|
#storage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.